diff options
author | Andrey Zhizhikin <andrey.z@gmail.com> | 2020-09-14 23:31:59 +0000 |
---|---|---|
committer | Richard Purdie <richard.purdie@linuxfoundation.org> | 2020-10-06 14:15:21 +0100 |
commit | 0d5448d77d02b0e7705b48b8348556a417a69919 (patch) | |
tree | bd44d82d57ee6933fcc2a9803f050e602fdb5d0c /meta/classes | |
parent | 460802161013f276b9ee5ce0ddc35799d39202fc (diff) | |
download | poky-0d5448d77d02b0e7705b48b8348556a417a69919.tar.gz |
insane: check for missing update-alternatives inherit
Add a package QA check to test if the recipe sets ALTERNATIVE variable
for any of its packages, and does not inherit update-alternatives class.
This causes the do_rootfs to fail since a proper alternative cannot be
created.
(From OE-Core rev: 0845f6b09716d927c586be5be878d08fa53b31d1)
Signed-off-by: Andrey Zhizhikin <andrey.z@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
(cherry picked from commit 24b5ccc76d5660fac38ac5346666380a0ecce359)
Signed-off-by: Steve Sakoman <steve@sakoman.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Diffstat (limited to 'meta/classes')
-rw-r--r-- | meta/classes/insane.bbclass | 9 |
1 files changed, 9 insertions, 0 deletions
diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass index 5b18fadd60..601b6b65bf 100644 --- a/meta/classes/insane.bbclass +++ b/meta/classes/insane.bbclass | |||
@@ -29,6 +29,7 @@ WARN_QA ?= "ldflags useless-rpaths rpaths staticdev libdir xorg-driver-abi \ | |||
29 | unknown-configure-option symlink-to-sysroot multilib \ | 29 | unknown-configure-option symlink-to-sysroot multilib \ |
30 | invalid-packageconfig host-user-contaminated uppercase-pn patch-fuzz \ | 30 | invalid-packageconfig host-user-contaminated uppercase-pn patch-fuzz \ |
31 | mime mime-xdg unlisted-pkg-lics unhandled-features-check \ | 31 | mime mime-xdg unlisted-pkg-lics unhandled-features-check \ |
32 | missing-update-alternatives \ | ||
32 | " | 33 | " |
33 | ERROR_QA ?= "dev-so debug-deps dev-deps debug-files arch pkgconfig la \ | 34 | ERROR_QA ?= "dev-so debug-deps dev-deps debug-files arch pkgconfig la \ |
34 | perms dep-cmp pkgvarcheck perm-config perm-line perm-link \ | 35 | perms dep-cmp pkgvarcheck perm-config perm-line perm-link \ |
@@ -988,6 +989,14 @@ def package_qa_check_unhandled_features_check(pn, d, messages): | |||
988 | if var_set: | 989 | if var_set: |
989 | package_qa_handle_error("unhandled-features-check", "%s: recipe doesn't inherit features_check" % pn, d) | 990 | package_qa_handle_error("unhandled-features-check", "%s: recipe doesn't inherit features_check" % pn, d) |
990 | 991 | ||
992 | QARECIPETEST[missing-update-alternatives] = "package_qa_check_missing_update_alternatives" | ||
993 | def package_qa_check_missing_update_alternatives(pn, d, messages): | ||
994 | # Look at all packages and find out if any of those sets ALTERNATIVE variable | ||
995 | # without inheriting update-alternatives class | ||
996 | for pkg in (d.getVar('PACKAGES') or '').split(): | ||
997 | if d.getVar('ALTERNATIVE_%s' % pkg) and not bb.data.inherits_class('update-alternatives', d): | ||
998 | package_qa_handle_error("missing-update-alternatives", "%s: recipe defines ALTERNATIVE_%s but doesn't inherit update-alternatives. This might fail during do_rootfs later!" % (pn, pkg), d) | ||
999 | |||
991 | # The PACKAGE FUNC to scan each package | 1000 | # The PACKAGE FUNC to scan each package |
992 | python do_package_qa () { | 1001 | python do_package_qa () { |
993 | import subprocess | 1002 | import subprocess |