summaryrefslogtreecommitdiffstats
path: root/meta/classes/staging.bbclass
diff options
context:
space:
mode:
authorRichard Purdie <richard.purdie@linuxfoundation.org>2017-01-23 17:43:40 +0000
committerRichard Purdie <richard.purdie@linuxfoundation.org>2017-01-23 23:30:57 +0000
commit6ab4c5033af72f102e7935de62e600b7ce247f34 (patch)
treedfc83f0cff8d54ce632b34be2e0c2257760ff226 /meta/classes/staging.bbclass
parent0a30ae5e18cd1c1576da80c3b9d31e8d64cfcc01 (diff)
downloadpoky-6ab4c5033af72f102e7935de62e600b7ce247f34.tar.gz
classes/oeqa: Replace subprocess.check_call() with check_output()
If you use subprocess.check_output() the traceback will contain the output when the command fails which is very useful for debugging. There is no good reason not to use this everywhere. (From OE-Core rev: ad750dd1cc9d789abe723daddd098ce41d8547f5) Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Diffstat (limited to 'meta/classes/staging.bbclass')
-rw-r--r--meta/classes/staging.bbclass6
1 files changed, 3 insertions, 3 deletions
diff --git a/meta/classes/staging.bbclass b/meta/classes/staging.bbclass
index 1a4668e5d3..fc387eaf4b 100644
--- a/meta/classes/staging.bbclass
+++ b/meta/classes/staging.bbclass
@@ -290,7 +290,7 @@ def staging_processfixme(fixme, target, recipesysroot, recipesysrootnative, d):
290 fixme_path = d.getVar(fixmevar) 290 fixme_path = d.getVar(fixmevar)
291 cmd += " -e 's:FIXME_%s:%s:g'" % (fixmevar, fixme_path) 291 cmd += " -e 's:FIXME_%s:%s:g'" % (fixmevar, fixme_path)
292 bb.note(cmd) 292 bb.note(cmd)
293 subprocess.check_call(cmd, shell=True) 293 subprocess.check_output(cmd, shell=True)
294 294
295 295
296def staging_populate_sysroot_dir(targetsysroot, nativesysroot, native, d): 296def staging_populate_sysroot_dir(targetsysroot, nativesysroot, native, d):
@@ -333,7 +333,7 @@ def staging_populate_sysroot_dir(targetsysroot, nativesysroot, native, d):
333 333
334 staging_processfixme(fixme, targetdir, targetsysroot, nativesysroot, d) 334 staging_processfixme(fixme, targetdir, targetsysroot, nativesysroot, d)
335 for p in postinsts: 335 for p in postinsts:
336 subprocess.check_call(p, shell=True) 336 subprocess.check_output(p, shell=True)
337 337
338# 338#
339# Manifests here are complicated. The main sysroot area has the unpacked sstate 339# Manifests here are complicated. The main sysroot area has the unpacked sstate
@@ -561,7 +561,7 @@ python extend_recipe_sysroot() {
561 staging_processfixme(fixme[f], multilibs[f].getVar("RECIPE_SYSROOT"), recipesysroot, recipesysrootnative, d) 561 staging_processfixme(fixme[f], multilibs[f].getVar("RECIPE_SYSROOT"), recipesysroot, recipesysrootnative, d)
562 562
563 for p in postinsts: 563 for p in postinsts:
564 subprocess.check_call(p, shell=True) 564 subprocess.check_output(p, shell=True)
565 565
566 for dep in configuredeps: 566 for dep in configuredeps:
567 c = setscenedeps[dep][0] 567 c = setscenedeps[dep][0]