diff options
author | Richard Purdie <richard.purdie@linuxfoundation.org> | 2017-01-23 17:43:40 +0000 |
---|---|---|
committer | Richard Purdie <richard.purdie@linuxfoundation.org> | 2017-01-23 23:30:57 +0000 |
commit | 6ab4c5033af72f102e7935de62e600b7ce247f34 (patch) | |
tree | dfc83f0cff8d54ce632b34be2e0c2257760ff226 /meta/classes/sstate.bbclass | |
parent | 0a30ae5e18cd1c1576da80c3b9d31e8d64cfcc01 (diff) | |
download | poky-6ab4c5033af72f102e7935de62e600b7ce247f34.tar.gz |
classes/oeqa: Replace subprocess.check_call() with check_output()
If you use subprocess.check_output() the traceback will contain the output
when the command fails which is very useful for debugging. There is no
good reason not to use this everywhere.
(From OE-Core rev: ad750dd1cc9d789abe723daddd098ce41d8547f5)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Diffstat (limited to 'meta/classes/sstate.bbclass')
-rw-r--r-- | meta/classes/sstate.bbclass | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/meta/classes/sstate.bbclass b/meta/classes/sstate.bbclass index a767a0203b..0fdeb9dfe8 100644 --- a/meta/classes/sstate.bbclass +++ b/meta/classes/sstate.bbclass | |||
@@ -573,14 +573,14 @@ python sstate_hardcode_path () { | |||
573 | sstate_hardcode_cmd = "%s | xargs %s | %s | xargs %s %s" % (sstate_scan_cmd, sstate_grep_cmd, sstate_filelist_cmd, xargs_no_empty_run_cmd, sstate_sed_cmd) | 573 | sstate_hardcode_cmd = "%s | xargs %s | %s | xargs %s %s" % (sstate_scan_cmd, sstate_grep_cmd, sstate_filelist_cmd, xargs_no_empty_run_cmd, sstate_sed_cmd) |
574 | 574 | ||
575 | bb.note("Removing hardcoded paths from sstate package: '%s'" % (sstate_hardcode_cmd)) | 575 | bb.note("Removing hardcoded paths from sstate package: '%s'" % (sstate_hardcode_cmd)) |
576 | subprocess.check_call(sstate_hardcode_cmd, shell=True, cwd=sstate_builddir) | 576 | subprocess.check_output(sstate_hardcode_cmd, shell=True, cwd=sstate_builddir) |
577 | 577 | ||
578 | # If the fixmefn is empty, remove it.. | 578 | # If the fixmefn is empty, remove it.. |
579 | if os.stat(fixmefn).st_size == 0: | 579 | if os.stat(fixmefn).st_size == 0: |
580 | os.remove(fixmefn) | 580 | os.remove(fixmefn) |
581 | else: | 581 | else: |
582 | bb.note("Replacing absolute paths in fixmepath file: '%s'" % (sstate_filelist_relative_cmd)) | 582 | bb.note("Replacing absolute paths in fixmepath file: '%s'" % (sstate_filelist_relative_cmd)) |
583 | subprocess.check_call(sstate_filelist_relative_cmd, shell=True) | 583 | subprocess.check_output(sstate_filelist_relative_cmd, shell=True) |
584 | } | 584 | } |
585 | 585 | ||
586 | def sstate_package(ss, d): | 586 | def sstate_package(ss, d): |