summaryrefslogtreecommitdiffstats
path: root/meta/classes/sanity.bbclass
diff options
context:
space:
mode:
authorJoshua Lock <josh@linux.intel.com>2010-11-26 16:43:05 +0000
committerRichard Purdie <rpurdie@linux.intel.com>2010-12-06 22:02:28 +0000
commit63b85e74a389da15a0034438f6792c4673273f32 (patch)
tree59f72c1fce88bc411ae9cee4d3729cafdf2892c7 /meta/classes/sanity.bbclass
parentd5f08073f5246c3f9fadf873e34ec02ec2050128 (diff)
downloadpoky-63b85e74a389da15a0034438f6792c4673273f32.tar.gz
sanity.bbclass: Warn people when TERMCMD is set to a non-installed program
We default to gnome-terminal for TERMCMD (and TERMRUNCMD) so should check that this program actually exists during sanity checking. As a corollary document how to change these variables in the local.conf Signed-off-by: Joshua Lock <josh@linux.intel.com>
Diffstat (limited to 'meta/classes/sanity.bbclass')
-rw-r--r--meta/classes/sanity.bbclass6
1 files changed, 6 insertions, 0 deletions
diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass
index 06aeddc3b0..e1f37ac1f4 100644
--- a/meta/classes/sanity.bbclass
+++ b/meta/classes/sanity.bbclass
@@ -139,6 +139,12 @@ def check_sanity(e):
139 missing = missing.rstrip(',') 139 missing = missing.rstrip(',')
140 messages = messages + "Please install following missing utilities: %s\n" % missing 140 messages = messages + "Please install following missing utilities: %s\n" % missing
141 141
142 # Ensure we have the binary for TERMCMD, as when patch application fails the error is fairly intimidating
143 termcmd = data.getVar("TERMCMD", e.data, True)
144 term = termcmd.split()[0]
145 if not check_app_exists(term, e.data):
146 messages = messages + "The console for use in patch error resolution is not available, please install %s or set TERMCMD and TERMCMDRUN (as documented in local.conf).\n" % term
147
142 if os.path.basename(os.readlink('/bin/sh')) == 'dash': 148 if os.path.basename(os.readlink('/bin/sh')) == 'dash':
143 messages = messages + "Using dash as /bin/sh causes various subtle build problems, please use bash instead (e.g. 'dpkg-reconfigure dash' on an Ubuntu system.\n" 149 messages = messages + "Using dash as /bin/sh causes various subtle build problems, please use bash instead (e.g. 'dpkg-reconfigure dash' on an Ubuntu system.\n"
144 150