diff options
author | Richard Purdie <richard.purdie@linuxfoundation.org> | 2014-11-05 18:44:24 +0000 |
---|---|---|
committer | Richard Purdie <richard.purdie@linuxfoundation.org> | 2014-11-09 10:21:19 +0000 |
commit | 593f14b2e3d1474d0c21d8d872dc7685163ffad2 (patch) | |
tree | f5435b3cad009f953faa0fadf1fcd93380ca6be3 /meta/classes/prserv.bbclass | |
parent | d01b8d556e6956f677dd1e07cb0f4d54507e7cdc (diff) | |
download | poky-593f14b2e3d1474d0c21d8d872dc7685163ffad2.tar.gz |
package/prserv: Merge two similar functions into one
Having these two separate functions handling PR values seems pointless,
and worse, there are impossible code branches mixed within them.
Merge them into one function and tweak comments so at least you
don't have to read both functions to figure out what is going on.
This does restructure the conditionals to try and aid readability.
(From OE-Core rev: 865d001de168915a5796e5c760f96bdd04cebd61)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Diffstat (limited to 'meta/classes/prserv.bbclass')
-rw-r--r-- | meta/classes/prserv.bbclass | 31 |
1 files changed, 0 insertions, 31 deletions
diff --git a/meta/classes/prserv.bbclass b/meta/classes/prserv.bbclass index b440d863ef..139597f9cb 100644 --- a/meta/classes/prserv.bbclass +++ b/meta/classes/prserv.bbclass | |||
@@ -1,33 +1,2 @@ | |||
1 | def prserv_get_pr_auto(d): | ||
2 | import oe.prservice | ||
3 | import re | ||
4 | 1 | ||
5 | pv = d.getVar("PV", True) | ||
6 | if not d.getVar('PRSERV_HOST', True): | ||
7 | if 'AUTOINC' in pv: | ||
8 | d.setVar("PKGV", pv.replace("AUTOINC", "0")) | ||
9 | bb.warn("Not using network based PR service") | ||
10 | return None | ||
11 | 2 | ||
12 | version = d.getVar("PRAUTOINX", True) | ||
13 | pkgarch = d.getVar("PACKAGE_ARCH", True) | ||
14 | checksum = d.getVar("BB_TASKHASH", True) | ||
15 | |||
16 | conn = d.getVar("__PRSERV_CONN", True) | ||
17 | if conn is None: | ||
18 | conn = oe.prservice.prserv_make_conn(d) | ||
19 | if conn is None: | ||
20 | return None | ||
21 | |||
22 | if "AUTOINC" in pv: | ||
23 | srcpv = bb.fetch2.get_srcrev(d) | ||
24 | base_ver = "AUTOINC-%s" % version[:version.find(srcpv)] | ||
25 | value = conn.getPR(base_ver, pkgarch, srcpv) | ||
26 | d.setVar("PKGV", pv.replace("AUTOINC", str(value))) | ||
27 | |||
28 | if d.getVar('PRSERV_LOCKDOWN', True): | ||
29 | auto_rev = d.getVar('PRAUTO_' + version + '_' + pkgarch, True) or d.getVar('PRAUTO_' + version, True) or None | ||
30 | else: | ||
31 | auto_rev = conn.getPR(version, pkgarch, checksum) | ||
32 | |||
33 | return auto_rev | ||