summaryrefslogtreecommitdiffstats
path: root/meta/classes/package.bbclass
diff options
context:
space:
mode:
authorUlf Magnusson <ulfalizer@gmail.com>2016-10-01 04:47:08 +0200
committerRichard Purdie <richard.purdie@linuxfoundation.org>2016-10-04 16:29:05 +0100
commit4dbb0d73dd7458dd67091afb250e4de976e68940 (patch)
treee204ef1e669a1a9190ec57aa602d4f7d7d026264 /meta/classes/package.bbclass
parent4c25460c5ae3b7779ced56ce8ed114d512e1f883 (diff)
downloadpoky-4dbb0d73dd7458dd67091afb250e4de976e68940.tar.gz
package.bbclass: Use bb.fatal() instead of raising FuncFailed
This sets a good example and avoids unnecessarily contributing to perceived complexity and cargo culting. Motivating quote below: < kergoth> the *original* intent was for the function/task to error via whatever appropriate means, bb.fatal, whatever, and funcfailed was what you'd catch if you were calling exec_func/exec_task. that is, it's what those functions raise, not what metadata functions should be raising < kergoth> it didn't end up being used that way < kergoth> but there's really never a reason to raise it yourself FuncFailed.__init__ takes a 'name' argument rather than a 'msg' argument, which also shows that the original purpose got lost. (From OE-Core rev: 8443b6f3f25181f5ac49bc25a1387cd05b814376) Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Diffstat (limited to 'meta/classes/package.bbclass')
-rw-r--r--meta/classes/package.bbclass2
1 files changed, 1 insertions, 1 deletions
diff --git a/meta/classes/package.bbclass b/meta/classes/package.bbclass
index a9ca14164b..a6f0a7a63d 100644
--- a/meta/classes/package.bbclass
+++ b/meta/classes/package.bbclass
@@ -1171,7 +1171,7 @@ python populate_packages () {
1171 continue 1171 continue
1172 ret = bb.utils.copyfile(file, fpath) 1172 ret = bb.utils.copyfile(file, fpath)
1173 if ret is False or ret == 0: 1173 if ret is False or ret == 0:
1174 raise bb.build.FuncFailed("File population failed") 1174 bb.fatal("File population failed")
1175 1175
1176 # Check if symlink paths exist 1176 # Check if symlink paths exist
1177 for file in symlink_paths: 1177 for file in symlink_paths: