diff options
author | Kai Kang <kai.kang@windriver.com> | 2019-11-19 11:15:14 +0800 |
---|---|---|
committer | Richard Purdie <richard.purdie@linuxfoundation.org> | 2019-11-29 17:43:39 +0000 |
commit | 47048bfd6416c6fdeb545f890f38d57a1390450e (patch) | |
tree | 15eb038d04eb4411ca99b8bdf11c09d6f0c85b1b /meta/classes/multilib.bbclass | |
parent | 5125464811acedd66f9f06f77d43dec0659e5ac6 (diff) | |
download | poky-47048bfd6416c6fdeb545f890f38d57a1390450e.tar.gz |
multilib.bbclass: fix qa warning of kernel-devicetree
When kernel-devicetree is in RRECOMMENDS such as via variable
MACHINE_EXTRA_RRECOMMENDS for some bsp, it shows QA warning of multilib:
| WARNING: lib32-packagegroup-base-1.0-r83 do_package: QA Issue:
| lib32-packagegroup-base package lib32-packagegroup-machine-base
| - suspicious values 'kernel-devicetree' in RRECOMMENDS [multilib]
Add kernel-devicetree to exceptions to fix the QA issue. Because there
are already 3 kernel related criteria, simplify them by judging package
names whether start with 'kernel-'. And also refactor to remove
duplicate 'not'.
(From OE-Core rev: 5e4504026c6358c7d5649843dc354247f5972558)
Signed-off-by: Kai Kang <kai.kang@windriver.com>
Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Diffstat (limited to 'meta/classes/multilib.bbclass')
-rw-r--r-- | meta/classes/multilib.bbclass | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/meta/classes/multilib.bbclass b/meta/classes/multilib.bbclass index 1a9295d36f..ee677da1e2 100644 --- a/meta/classes/multilib.bbclass +++ b/meta/classes/multilib.bbclass | |||
@@ -184,11 +184,12 @@ python do_package_qa_multilib() { | |||
184 | for i in values: | 184 | for i in values: |
185 | if i.startswith('virtual/'): | 185 | if i.startswith('virtual/'): |
186 | i = i[len('virtual/'):] | 186 | i = i[len('virtual/'):] |
187 | if (not i.startswith('kernel-module')) and (not i.startswith(mlprefix)) and \ | 187 | |
188 | (not 'cross-canadian' in i) and (not i.startswith("nativesdk-")) and \ | 188 | if (not (i.startswith(mlprefix) or i.startswith("kernel-") \ |
189 | (not i.startswith("rtld")) and (not i.startswith('kernel-vmlinux')) \ | 189 | or ('cross-canadian' in i) or i.startswith("nativesdk-") \ |
190 | and (not i.startswith("kernel-image")) and (not i.startswith("/")): | 190 | or i.startswith("rtld") or i.startswith("/"))): |
191 | candidates.append(i) | 191 | candidates.append(i) |
192 | |||
192 | if len(candidates) > 0: | 193 | if len(candidates) > 0: |
193 | msg = "%s package %s - suspicious values '%s' in %s" \ | 194 | msg = "%s package %s - suspicious values '%s' in %s" \ |
194 | % (d.getVar('PN'), pkg, ' '.join(candidates), var) | 195 | % (d.getVar('PN'), pkg, ' '.join(candidates), var) |