diff options
author | Phil Blundell <philb@gnu.org> | 2012-10-15 11:28:00 +0100 |
---|---|---|
committer | Richard Purdie <richard.purdie@linuxfoundation.org> | 2012-10-18 12:13:49 +0100 |
commit | 0fd014eadac6451d7be40d7332d14c5bcd84dfea (patch) | |
tree | 840fd291da4d9079534a67460ade9b95b83ff4b6 /meta/classes/insane.bbclass | |
parent | f8c90bce73647f11658edcd2dda9a3c3bfd8b274 (diff) | |
download | poky-0fd014eadac6451d7be40d7332d14c5bcd84dfea.tar.gz |
insane: Don't try to run objdump on symlinks
If the link is absolute then we might end up reading from a host binary
or a nonexistent path, neither of which will produce useful results and
may result in objdump failure and python backtrace spew. If the link
does point to a binary within the installation root then we will scan the
pointed-to file at some point anyway so there is no need to do it again.
(From OE-Core rev: 91769af1c1175ac9bb43d16d05fb1c8736dd9287)
Signed-off-by: Phil Blundell <pb@pbcl.net>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Diffstat (limited to 'meta/classes/insane.bbclass')
-rw-r--r-- | meta/classes/insane.bbclass | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass index 2b4841933c..71a9a588c3 100644 --- a/meta/classes/insane.bbclass +++ b/meta/classes/insane.bbclass | |||
@@ -157,6 +157,9 @@ def package_qa_check_rpath(file,name, d, elf, messages): | |||
157 | if not elf: | 157 | if not elf: |
158 | return | 158 | return |
159 | 159 | ||
160 | if os.path.islink(file): | ||
161 | return | ||
162 | |||
160 | bad_dirs = [d.getVar('TMPDIR', True) + "/work", d.getVar('STAGING_DIR_TARGET', True)] | 163 | bad_dirs = [d.getVar('TMPDIR', True) + "/work", d.getVar('STAGING_DIR_TARGET', True)] |
161 | bad_dir_test = d.getVar('TMPDIR', True) | 164 | bad_dir_test = d.getVar('TMPDIR', True) |
162 | 165 | ||
@@ -186,6 +189,9 @@ def package_qa_check_useless_rpaths(file, name, d, elf, messages): | |||
186 | if not elf: | 189 | if not elf: |
187 | return | 190 | return |
188 | 191 | ||
192 | if os.path.islink(file): | ||
193 | return | ||
194 | |||
189 | libdir = d.getVar("libdir", True) | 195 | libdir = d.getVar("libdir", True) |
190 | base_libdir = d.getVar("base_libdir", True) | 196 | base_libdir = d.getVar("base_libdir", True) |
191 | 197 | ||