diff options
author | Ross Burton <ross.burton@intel.com> | 2019-11-26 23:35:09 +0000 |
---|---|---|
committer | Richard Purdie <richard.purdie@linuxfoundation.org> | 2019-11-29 17:43:40 +0000 |
commit | 8a3a1e4a350657050eb04564ce2c49db82af86e5 (patch) | |
tree | aaaa46d6d1c45510bdaa605dfcf746b8cec510f4 /meta/classes/insane.bbclass | |
parent | c534b4640a026a6036e17e7543f3b1d8fe2ffc5e (diff) | |
download | poky-8a3a1e4a350657050eb04564ce2c49db82af86e5.tar.gz |
insane: fix GitHub /archive/ test
This test was failing to split the URL list to individual URLs, so if
SRC_URI is something like this then the test incorrectly triggers:
SRC_URI = "git://github.com/foo http://example.com/archive/foo"
Fix this by splitting the SRC_URI list and iterating through the URIs
one at time.
[ YOCTO #13660 ]
(From OE-Core rev: ddd2c5624404848ee668dabec0f61599ab5003e4)
Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Diffstat (limited to 'meta/classes/insane.bbclass')
-rw-r--r-- | meta/classes/insane.bbclass | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass index f856cf6a2b..0564f9c2a4 100644 --- a/meta/classes/insane.bbclass +++ b/meta/classes/insane.bbclass | |||
@@ -893,9 +893,9 @@ def package_qa_check_src_uri(pn, d, messages): | |||
893 | if "${PN}" in d.getVar("SRC_URI", False): | 893 | if "${PN}" in d.getVar("SRC_URI", False): |
894 | package_qa_handle_error("src-uri-bad", "%s: SRC_URI uses PN not BPN" % pn, d) | 894 | package_qa_handle_error("src-uri-bad", "%s: SRC_URI uses PN not BPN" % pn, d) |
895 | 895 | ||
896 | pn = d.getVar("SRC_URI") | 896 | for url in d.getVar("SRC_URI").split(): |
897 | if re.search(r"github\.com/.+/.+/archive/.+", pn): | 897 | if re.search(r"github\.com/.+/.+/archive/.+", url): |
898 | package_qa_handle_error("src-uri-bad", "%s: SRC_URI uses unstable GitHub archives" % pn, d) | 898 | package_qa_handle_error("src-uri-bad", "%s: SRC_URI uses unstable GitHub archives" % pn, d) |
899 | 899 | ||
900 | 900 | ||
901 | # The PACKAGE FUNC to scan each package | 901 | # The PACKAGE FUNC to scan each package |