diff options
author | Robert Yang <liezhi.yang@windriver.com> | 2012-05-29 22:53:06 +0800 |
---|---|---|
committer | Richard Purdie <richard.purdie@linuxfoundation.org> | 2012-05-30 12:04:45 +0100 |
commit | e40995e569289598a1d9d71e19734402f2b54718 (patch) | |
tree | 108328e272a149da0e27dec0e0f0bebe602b80b8 /meta/classes/distrodata.bbclass | |
parent | e4c35790d6dc23a0933f188f52fa4434784e1d98 (diff) | |
download | poky-e40995e569289598a1d9d71e19734402f2b54718.tar.gz |
meta: replace os.system with subprocess.call
Replace os.system with subprocess.call since the older function would
fail (more or less) silently if the executed program cannot be found
More info:
http://docs.python.org/library/subprocess.html#subprocess-replacements
[YOCTO #2454]
(From OE-Core rev: a07d03cc6f67c88feb9813ae7deb6e4a93552dfe)
Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Diffstat (limited to 'meta/classes/distrodata.bbclass')
-rw-r--r-- | meta/classes/distrodata.bbclass | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/meta/classes/distrodata.bbclass b/meta/classes/distrodata.bbclass index 4b2dee5b10..df6d300666 100644 --- a/meta/classes/distrodata.bbclass +++ b/meta/classes/distrodata.bbclass | |||
@@ -231,6 +231,7 @@ python do_checkpkg() { | |||
231 | import sys | 231 | import sys |
232 | import re | 232 | import re |
233 | import tempfile | 233 | import tempfile |
234 | import subprocess | ||
234 | 235 | ||
235 | """ | 236 | """ |
236 | sanity check to ensure same name and type. Match as many patterns as possible | 237 | sanity check to ensure same name and type. Match as many patterns as possible |
@@ -373,7 +374,7 @@ python do_checkpkg() { | |||
373 | f.close() | 374 | f.close() |
374 | if status != "ErrHostNoDir" and re.match("Err", status): | 375 | if status != "ErrHostNoDir" and re.match("Err", status): |
375 | logpath = d.getVar('LOG_DIR', True) | 376 | logpath = d.getVar('LOG_DIR', True) |
376 | os.system("cp %s %s/" % (f.name, logpath)) | 377 | subprocess.call("cp %s %s/" % (f.name, logpath), shell=True) |
377 | os.unlink(f.name) | 378 | os.unlink(f.name) |
378 | return status | 379 | return status |
379 | 380 | ||
@@ -432,7 +433,7 @@ python do_checkpkg() { | |||
432 | """if host hasn't directory information, no need to save tmp file""" | 433 | """if host hasn't directory information, no need to save tmp file""" |
433 | if status != "ErrHostNoDir" and re.match("Err", status): | 434 | if status != "ErrHostNoDir" and re.match("Err", status): |
434 | logpath = d.getVar('LOG_DIR', True) | 435 | logpath = d.getVar('LOG_DIR', True) |
435 | os.system("cp %s %s/" % (f.name, logpath)) | 436 | subprocess.call("cp %s %s/" % (f.name, logpath), shell=True) |
436 | os.unlink(f.name) | 437 | os.unlink(f.name) |
437 | return status | 438 | return status |
438 | 439 | ||