utils.bbclass: add function to check for git config user

If attempting to patch a git repo without a proper git config setup,
an error will occur saying user.name/user.email are needed by git
am/apply. After some code was removed from kernel-yocto, it was
simple enough to reproduce this error by creating a kernel patch and
using a container to build.

This patch abstracts out functionality that existed in buildhistory
for use in other classes. It also adds a call to this functionality
to the kernel-yocto class.

Fixes [YOCTO #10346]

introduced in OE-core revision
0f698dfd1c8bbc0d53ae7977e26685a7a3df52a3

(From OE-Core rev: 25b43cb05c645e43f96bc18906441b8fdc272228)

Signed-off-by: Stephano Cetola <stephano.cetola@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>

1 files changed, 6 insertions, 9 deletions

diff --git a/meta/classes/buildhistory.bbclass b/meta/classes/buildhistory.bbclass
index 6e5de0ef69..3a5bc2c3e3 100644
--- a/meta/classes/buildhistory.bbclass
+++ b/meta/classes/buildhistory.bbclass
@@ -57,6 +57,9 @@ SSTATEPOSTINSTFUNCS[vardepvalueexclude] .= "| buildhistory_emit_pkghistory"
 # class.
 BUILDHISTORY_PRESERVE = "latest latest_srcrev"
 
+PATCH_GIT_USER_EMAIL ?= "buildhistory@oe"
+PATCH_GIT_USER_NAME ?= "OpenEmbedded"
+
 #
 # Write out metadata about this package for comparison when writing future packages
 #
@@ -708,15 +711,9 @@ END
                         git tag -f build-minus-2 build-minus-1 > /dev/null 2>&1 || true
                         git tag -f build-minus-1 > /dev/null 2>&1 || true
                 fi
-                # If the user hasn't set up their name/email, set some defaults
-                # just for this repo (otherwise the commit will fail with older
-                # versions of git)
-                if ! git config user.email > /dev/null ; then
-                        git config --local user.email "buildhistory@${DISTRO}"
-                fi
-                if ! git config user.name > /dev/null ; then
-                        git config --local user.name "buildhistory"
-                fi
+
+                check_git_config
+
                 # Check if there are new/changed files to commit (other than metadata-revs)
                 repostatus=`git status --porcelain | grep -v " metadata-revs$"`
                 HOSTNAME=`hostname 2>/dev/null || echo unknown`