diff options
author | Ulf Magnusson <ulfalizer@gmail.com> | 2016-10-01 04:46:56 +0200 |
---|---|---|
committer | Richard Purdie <richard.purdie@linuxfoundation.org> | 2016-10-04 16:29:04 +0100 |
commit | 46398106efceba33715f9e6910b965629306fbdc (patch) | |
tree | 554859f8ff98be7627bd83e954f161d2061a0240 /meta/classes/blacklist.bbclass | |
parent | 103ab2d8105101ae1dd742d4fcd57d40d3ab2da3 (diff) | |
download | poky-46398106efceba33715f9e6910b965629306fbdc.tar.gz |
syslinux.bbclass: Use bb.fatal() instead of raising FuncFailed
This sets a good example and avoids unnecessarily contributing to
perceived complexity and cargo culting.
Motivating quote below:
< kergoth> the *original* intent was for the function/task to error via
whatever appropriate means, bb.fatal, whatever, and
funcfailed was what you'd catch if you were calling
exec_func/exec_task. that is, it's what those functions
raise, not what metadata functions should be raising
< kergoth> it didn't end up being used that way
< kergoth> but there's really never a reason to raise it yourself
FuncFailed.__init__ takes a 'name' argument rather than a 'msg'
argument, which also shows that the original purpose got lost.
(From OE-Core rev: cca772ecf0adafbd767974add27ada125aae5269)
Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Diffstat (limited to 'meta/classes/blacklist.bbclass')
0 files changed, 0 insertions, 0 deletions