diff options
author | Belen Barros Pena <belen.barros.pena@intel.com> | 2016-02-10 00:05:06 +0000 |
---|---|---|
committer | Richard Purdie <richard.purdie@linuxfoundation.org> | 2016-02-10 13:33:40 +0000 |
commit | 4d0ba0fca859973ff68dc5e929f19f3c4bcb10f5 (patch) | |
tree | 2fcc8a6d0f2714916d7a107cc516f900cada8693 /bitbake | |
parent | 99184d7879723f73b67dccf3754263729662cbea (diff) | |
download | poky-4d0ba0fca859973ff68dc5e929f19f3c4bcb10f5.tar.gz |
bitbake: toaster: templates make build data breadcrumb consistent
The pages in the build data section of Toaster showed different
breadcrumbs: in some pages the machine was displayed, but not in others.
For builds with more than one target, some pages showed the first
alphabetical target (the correct behaviour), others didn't.
This patch removes the inconsistencies, showing exactly the same
breacrumb across all pages in the section.
The patch also removes the extra space between the '+' and the number of
targets when the builds have more than one target.
Remove an unneeded debug message
(Bitbake rev: 9cdbb543311b6f4a8a88c27fc157d998242444ee)
Signed-off-by: Belen Barros Pena <belen.barros.pena@intel.com>
Signed-off-by: Michael Wood <michael.g.wood@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Diffstat (limited to 'bitbake')
3 files changed, 3 insertions, 5 deletions
diff --git a/bitbake/lib/toaster/toastergui/templates/basebuilddetailpage.html b/bitbake/lib/toaster/toastergui/templates/basebuilddetailpage.html index 22ca50c0c3..ffe7aa4f8d 100644 --- a/bitbake/lib/toaster/toastergui/templates/basebuilddetailpage.html +++ b/bitbake/lib/toaster/toastergui/templates/basebuilddetailpage.html | |||
@@ -8,7 +8,7 @@ | |||
8 | <ul class="breadcrumb" id="breadcrumb"> | 8 | <ul class="breadcrumb" id="breadcrumb"> |
9 | <li class="muted">{{build.project.name}}:</li> | 9 | <li class="muted">{{build.project.name}}:</li> |
10 | <li><a href="{% url 'projectbuilds' build.project.id %}">Builds</a></li> | 10 | <li><a href="{% url 'projectbuilds' build.project.id %}">Builds</a></li> |
11 | <li><a href="{%url 'builddashboard' build.pk%}">{{build.target_set.all.0.target}} {%if build.target_set.all.count > 1%}(+ {{build.target_set.all.count|add:"-1"}}){%endif%} ({{build.completed_on|date:"d/m/y H:i"}})</a></li> | 11 | <li><a href="{%url 'builddashboard' build.pk%}">{{build.get_sorted_target_list.0.target}} {%if build.target_set.all.count > 1%}(+{{build.target_set.all.count|add:"-1"}}){%endif%} {{build.machine}} ({{build.completed_on|date:"d/m/y H:i"}})</a></li> |
12 | {% block localbreadcrumb %}{% endblock %} | 12 | {% block localbreadcrumb %}{% endblock %} |
13 | </ul> | 13 | </ul> |
14 | <script> | 14 | <script> |
diff --git a/bitbake/lib/toaster/toastergui/templates/basebuildpage.html b/bitbake/lib/toaster/toastergui/templates/basebuildpage.html index d441df84e0..a9048d3bb2 100644 --- a/bitbake/lib/toaster/toastergui/templates/basebuildpage.html +++ b/bitbake/lib/toaster/toastergui/templates/basebuildpage.html | |||
@@ -13,7 +13,7 @@ | |||
13 | <li> | 13 | <li> |
14 | {% block parentbreadcrumb %} | 14 | {% block parentbreadcrumb %} |
15 | <a href="{%url 'builddashboard' build.pk%}"> | 15 | <a href="{%url 'builddashboard' build.pk%}"> |
16 | {{build.get_sorted_target_list.0.target}} {%if build.target_set.all.count > 1%}(+ {{build.target_set.all.count|add:"-1"}}){%endif%} ({{build.completed_on|date:"d/m/y H:i"}}) | 16 | {{build.get_sorted_target_list.0.target}} {%if build.target_set.all.count > 1%}(+{{build.target_set.all.count|add:"-1"}}){%endif%} {{build.machine}} ({{build.completed_on|date:"d/m/y H:i"}}) |
17 | </a> | 17 | </a> |
18 | {% endblock %} | 18 | {% endblock %} |
19 | </li> | 19 | </li> |
@@ -24,7 +24,6 @@ | |||
24 | $('#breadcrumb > li').append('<span class="divider">→</span>'); | 24 | $('#breadcrumb > li').append('<span class="divider">→</span>'); |
25 | $('#breadcrumb > li:last').addClass("active"); | 25 | $('#breadcrumb > li:last').addClass("active"); |
26 | $('#breadcrumb > li:last > span, #breadcrumb > li:first > span').remove(); | 26 | $('#breadcrumb > li:last > span, #breadcrumb > li:first > span').remove(); |
27 | console.log("done"); | ||
28 | }); | 27 | }); |
29 | </script> | 28 | </script> |
30 | </div> | 29 | </div> |
diff --git a/bitbake/lib/toaster/toastergui/templates/builddashboard.html b/bitbake/lib/toaster/toastergui/templates/builddashboard.html index 323bbbb6e2..7857abaaac 100644 --- a/bitbake/lib/toaster/toastergui/templates/builddashboard.html +++ b/bitbake/lib/toaster/toastergui/templates/builddashboard.html | |||
@@ -6,10 +6,9 @@ | |||
6 | {% block parentbreadcrumb %} | 6 | {% block parentbreadcrumb %} |
7 | {% if build.get_sorted_target_list.count > 0 %} | 7 | {% if build.get_sorted_target_list.count > 0 %} |
8 | {{build.get_sorted_target_list.0.target}} | 8 | {{build.get_sorted_target_list.0.target}} |
9 | | ||
10 | {% endif %} | 9 | {% endif %} |
11 | 10 | ||
12 | {%if build.target_set.all.count > 1%}(+ {{build.target_set.all.count|add:"-1"}}){%endif%} {{build.machine}} ({{build.completed_on|date:"d/m/y H:i"}}) | 11 | {%if build.target_set.all.count > 1%}(+{{build.target_set.all.count|add:"-1"}}){%endif%} {{build.machine}} ({{build.completed_on|date:"d/m/y H:i"}}) |
13 | {% endblock %} | 12 | {% endblock %} |
14 | 13 | ||
15 | {% block buildinfomain %} | 14 | {% block buildinfomain %} |