diff options
author | Awais Belal <awais_belal@mentor.com> | 2018-09-05 22:26:43 -0700 |
---|---|---|
committer | Richard Purdie <richard.purdie@linuxfoundation.org> | 2018-09-10 12:15:04 +0100 |
commit | 61428c05bb5e76aa1f93259174a1b477bd278dc1 (patch) | |
tree | 67be4e99303a5c89b6f0c2e7e9b01be4c70c2234 /bitbake | |
parent | 90a9b1b0f5cd558eedaac373c770379ee50e5f05 (diff) | |
download | poky-61428c05bb5e76aa1f93259174a1b477bd278dc1.tar.gz |
bitbake: toaster/widgets.py: avoid divide by zero issues
There can be cases where the variables being used
to divide in build percentage expressions can be
zero. For example, a setup consisting of only local
repos will have repos_to_clone=0 and will generate
a divide by zero scenario.
Fix this by checking the divisor in such cases.
[YOCTO #12891]
(Bitbake rev: 30702f29928c3b088f199bf8b1609b2956f8c47a)
Signed-off-by: Awais Belal <awais_belal@mentor.com>
Signed-off-by: David Reyna <David.Reyna@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Diffstat (limited to 'bitbake')
-rw-r--r-- | bitbake/lib/toaster/toastergui/widgets.py | 19 |
1 files changed, 12 insertions, 7 deletions
diff --git a/bitbake/lib/toaster/toastergui/widgets.py b/bitbake/lib/toaster/toastergui/widgets.py index a1792d997f..feef7c5d95 100644 --- a/bitbake/lib/toaster/toastergui/widgets.py +++ b/bitbake/lib/toaster/toastergui/widgets.py | |||
@@ -511,13 +511,18 @@ class MostRecentBuildsView(View): | |||
511 | buildrequest_id = build_obj.buildrequest.pk | 511 | buildrequest_id = build_obj.buildrequest.pk |
512 | build['buildrequest_id'] = buildrequest_id | 512 | build['buildrequest_id'] = buildrequest_id |
513 | 513 | ||
514 | build['recipes_parsed_percentage'] = \ | 514 | if build_obj.recipes_to_parse > 0: |
515 | int((build_obj.recipes_parsed / | 515 | build['recipes_parsed_percentage'] = \ |
516 | build_obj.recipes_to_parse) * 100) | 516 | int((build_obj.recipes_parsed / |
517 | 517 | build_obj.recipes_to_parse) * 100) | |
518 | build['repos_cloned_percentage'] = \ | 518 | else: |
519 | int((build_obj.repos_cloned / | 519 | build['recipes_parsed_percentage'] = 0 |
520 | build_obj.repos_to_clone) * 100) | 520 | if build_obj.repos_to_clone > 0: |
521 | build['repos_cloned_percentage'] = \ | ||
522 | int((build_obj.repos_cloned / | ||
523 | build_obj.repos_to_clone) * 100) | ||
524 | else: | ||
525 | build['repos_cloned_percentage'] = 0 | ||
521 | 526 | ||
522 | tasks_complete_percentage = 0 | 527 | tasks_complete_percentage = 0 |
523 | if build_obj.outcome in (Build.SUCCEEDED, Build.FAILED): | 528 | if build_obj.outcome in (Build.SUCCEEDED, Build.FAILED): |