summaryrefslogtreecommitdiffstats
path: root/bitbake
diff options
context:
space:
mode:
authorRichard Purdie <richard.purdie@linuxfoundation.org>2023-03-10 21:46:01 +0100
committerRichard Purdie <richard.purdie@linuxfoundation.org>2023-03-14 15:05:30 +0000
commit432bef2a904883fe206b136393d976dc662cb30f (patch)
tree17944866e19f5471fe3bffeb525169c2032d82ae /bitbake
parentf8c7c22df834199cfae361965f34833fd365292f (diff)
downloadpoky-432bef2a904883fe206b136393d976dc662cb30f.tar.gz
bitbake: cookerdata: Drop dubious exception handling code
This code appears to be dangerous, it swallows exceptions, turning them into "handled" versions which then show no errors to the user. This is a pretty poor user experience and I can't see why this code should be swallowing such things. Drop the worst bits of code. (Bitbake rev: a29ffcc12df24737e702e198aeb8f6892884932b) Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> Signed-off-by: Steve Sakoman <steve@sakoman.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Diffstat (limited to 'bitbake')
-rw-r--r--bitbake/lib/bb/cookerdata.py5
1 files changed, 0 insertions, 5 deletions
diff --git a/bitbake/lib/bb/cookerdata.py b/bitbake/lib/bb/cookerdata.py
index e2dbb3b21c..ec3741cc1d 100644
--- a/bitbake/lib/bb/cookerdata.py
+++ b/bitbake/lib/bb/cookerdata.py
@@ -293,14 +293,9 @@ class CookerDataBuilder(object):
293 bb.event.fire(bb.event.MultiConfigParsed(self.mcdata), self.data) 293 bb.event.fire(bb.event.MultiConfigParsed(self.mcdata), self.data)
294 294
295 self.data_hash = data_hash.hexdigest() 295 self.data_hash = data_hash.hexdigest()
296 except (SyntaxError, bb.BBHandledException):
297 raise bb.BBHandledException()
298 except bb.data_smart.ExpansionError as e: 296 except bb.data_smart.ExpansionError as e:
299 logger.error(str(e)) 297 logger.error(str(e))
300 raise bb.BBHandledException() 298 raise bb.BBHandledException()
301 except Exception:
302 logger.exception("Error parsing configuration files")
303 raise bb.BBHandledException()
304 299
305 300
306 # Handle obsolete variable names 301 # Handle obsolete variable names