diff options
author | Alexandru Damian <alexandru.damian@intel.com> | 2015-08-18 17:28:57 +0100 |
---|---|---|
committer | Richard Purdie <richard.purdie@linuxfoundation.org> | 2015-08-19 18:05:55 +0100 |
commit | c9455a7484fa5ead1a90e40b78512867b4285020 (patch) | |
tree | 152a114ce3e7e528d3b3c0331c39e737b6bafd7d /bitbake/lib/toaster/toastergui | |
parent | 07b58c97342d4f2efff80891981e8ee63dd198d0 (diff) | |
download | poky-c9455a7484fa5ead1a90e40b78512867b4285020.tar.gz |
bitbake: toaster: fix pylint errors
Prompted by issues discovered during running pylint on
the toaster sources, this patch fixes:
* missing import in toaster ui
* improper call of function in toaster ui (logger.debug)
* improper function definitions in bbcontroller
* invalid references to objects in bldcontrol.models
* proper initialization of object fields in ToasterTables
Also inhibiting specific pylint errors in files where
the problems are mis-identified.
(Bitbake rev: 1c71955c416fb68455f7f70669aba4202c411807)
Signed-off-by: Alexandru Damian <alexandru.damian@intel.com>
Signed-off-by: Michael Wood <michael.g.wood@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Diffstat (limited to 'bitbake/lib/toaster/toastergui')
-rwxr-xr-x | bitbake/lib/toaster/toastergui/views.py | 4 | ||||
-rw-r--r-- | bitbake/lib/toaster/toastergui/widgets.py | 3 |
2 files changed, 7 insertions, 0 deletions
diff --git a/bitbake/lib/toaster/toastergui/views.py b/bitbake/lib/toaster/toastergui/views.py index 2aadc75b9e..586a69c314 100755 --- a/bitbake/lib/toaster/toastergui/views.py +++ b/bitbake/lib/toaster/toastergui/views.py | |||
@@ -19,6 +19,10 @@ | |||
19 | # with this program; if not, write to the Free Software Foundation, Inc., | 19 | # with this program; if not, write to the Free Software Foundation, Inc., |
20 | # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. | 20 | # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. |
21 | 21 | ||
22 | # pylint: disable=method-hidden | ||
23 | # Gives E:848, 4: An attribute defined in json.encoder line 162 hides this method (method-hidden) | ||
24 | # which is an invalid warning | ||
25 | |||
22 | import operator,re | 26 | import operator,re |
23 | 27 | ||
24 | from django.db.models import F, Q, Sum, Count, Max | 28 | from django.db.models import F, Q, Sum, Count, Max |
diff --git a/bitbake/lib/toaster/toastergui/widgets.py b/bitbake/lib/toaster/toastergui/widgets.py index 2adf574783..eb2914d87c 100644 --- a/bitbake/lib/toaster/toastergui/widgets.py +++ b/bitbake/lib/toaster/toastergui/widgets.py | |||
@@ -334,6 +334,9 @@ class ToasterTemplateView(TemplateView): | |||
334 | # renders a instance in a template, or returns the context as json | 334 | # renders a instance in a template, or returns the context as json |
335 | # the class-equivalent of the _template_renderer decorator for views | 335 | # the class-equivalent of the _template_renderer decorator for views |
336 | 336 | ||
337 | def __init__(self, *args, **kwargs): | ||
338 | super(ToasterTemplateView, self).__init__(*args, **kwargs) | ||
339 | self.context_entries = [] | ||
337 | 340 | ||
338 | def get(self, *args, **kwargs): | 341 | def get(self, *args, **kwargs): |
339 | if self.request.GET.get('format', None) == 'json': | 342 | if self.request.GET.get('format', None) == 'json': |