diff options
author | Ed Bartosh <ed.bartosh@linux.intel.com> | 2016-06-10 12:34:12 +0300 |
---|---|---|
committer | Richard Purdie <richard.purdie@linuxfoundation.org> | 2016-06-15 08:35:06 +0100 |
commit | aa6894a4369dbbd032a98bfe43b285111261efa9 (patch) | |
tree | 2fe0bb1b09d1fe1551899bfdbf324c75370fac45 /bitbake/lib/toaster/toastergui/views.py | |
parent | eb634f9e13ade09b4fc7d69801f4d9e21ef03db1 (diff) | |
download | poky-aa6894a4369dbbd032a98bfe43b285111261efa9.tar.gz |
bitbake: toaster: fix wrong usage of print_exc and format_exc
First parameter of traceback.print_exc and traceback.format_exc APIs is
a 'limit' - a number of stracktraces to print.
Passing exception object to print_exc or format_exc is incorrect, but
it works in Python 2 and causes printing only one line of traceback.
In Python 3 comparison of integer and exception object throws exception:
TypeError: unorderable types: int() < <Exception type>()
As these APIs are usually used in except block of handling another
exception this can cause hard to find and debug bugs.
(Bitbake rev: c5a48931ac8db9e56f978c50861c19d0d0c808e3)
Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com>
Signed-off-by: Michael Wood <michael.g.wood@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Diffstat (limited to 'bitbake/lib/toaster/toastergui/views.py')
-rwxr-xr-x | bitbake/lib/toaster/toastergui/views.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/bitbake/lib/toaster/toastergui/views.py b/bitbake/lib/toaster/toastergui/views.py index 5ceeb6be3e..02548761f0 100755 --- a/bitbake/lib/toaster/toastergui/views.py +++ b/bitbake/lib/toaster/toastergui/views.py | |||
@@ -761,7 +761,7 @@ def _get_dir_entries(build_id, target_id, start): | |||
761 | 761 | ||
762 | except Exception as e: | 762 | except Exception as e: |
763 | print("Exception ", e) | 763 | print("Exception ", e) |
764 | traceback.print_exc(e) | 764 | traceback.print_exc() |
765 | 765 | ||
766 | # sort by directories first, then by name | 766 | # sort by directories first, then by name |
767 | rsorted = sorted(response, key=lambda entry : entry['name']) | 767 | rsorted = sorted(response, key=lambda entry : entry['name']) |