diff options
author | Dave Lerner <dave.lerner@windriver.com> | 2014-04-08 16:32:21 +0000 |
---|---|---|
committer | Richard Purdie <richard.purdie@linuxfoundation.org> | 2014-04-09 17:00:02 +0100 |
commit | d3e5632efb1f10143c748c169f6439f39eb3cf21 (patch) | |
tree | 8e6709581e91d2d8f46856656560d18ea78063fd /bitbake/lib/toaster/toastergui/templates/bpackage.html | |
parent | dc7d3d29108d63eb5ecf276769f0099a5bc3ab86 (diff) | |
download | poky-d3e5632efb1f10143c748c169f6439f39eb3cf21.tar.gz |
bitbake: toaster: sort on size in detail pages
[YOCTO 5778]
Implements the features described in the attachment to bugzilla 5778
- new global changes to the format of size data, and
- adding sorts by selected columns to specific detail pages.
Although new pagination and row search capabilities are shown on the
screen shots for the 5778 attachment, those features are specified in
a different bugzilla entry 5777 and are not implemented in this commit.
Also, the 5778 spec includes table sorting for the recipe package
detail page, but sorting for that page was not implemented in this
commit due to complications with sorting then returning to a page that
is only one URL fragment in a template.
The scope of file changes are described below.
Changes to support new 'size' field column formats...
default.css - added sizecol class style (right justified)
projecttags.py - changed filtered_filesizeformat to allow
".0" suffixes
Changes that add class 'sizecol, span2(as spec'd) ' to <th> and/or
<td> size columns were made to...
dirinfo.py,
package_built_dependencies.html,
package_included_dependencies.html,
recipe.html,
bpackage.html, and
target.html
More significant changes to support detail page table sorting
are:
- tablesort.html: New created to implement the sort icons,
directions, and table headings, and
suppress sort handling if 'disable_sort' in context,
without search or pagination elements ingrained
in basetable_top. Confining the changes to this small file
reduces the impact (testing and risk) on the larger set of
files that arleady include basetable_top/bottom files.
- view.py: Modified the following view functions with
- trivial changes for size formatting to the views: target,
- changes to package_built_detail, package_included_detail,
package_included_reverse_dependencies to handle the sorting
implementation as well as moving headings and size
formatting for size columns from templates to the views.
- Implementation of the detail sorting using above in:
package_built_detail.html,
package_included_detail.html, and
package_included_reverse_dependencies.html
to include the tablesort heading setup, format the size column,
and iterate over the new sorted objects, suppressing sorts if
table row count less than 2.
(Bitbake rev: d16126e9abfffde66ab70865a81997322847d44e)
Signed-off-by: Dave Lerner <dave.lerner@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Diffstat (limited to 'bitbake/lib/toaster/toastergui/templates/bpackage.html')
-rw-r--r-- | bitbake/lib/toaster/toastergui/templates/bpackage.html | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/bitbake/lib/toaster/toastergui/templates/bpackage.html b/bitbake/lib/toaster/toastergui/templates/bpackage.html index c6ec634f83..2d4948be4b 100644 --- a/bitbake/lib/toaster/toastergui/templates/bpackage.html +++ b/bitbake/lib/toaster/toastergui/templates/bpackage.html | |||
@@ -64,7 +64,7 @@ | |||
64 | <!-- Package Version --> | 64 | <!-- Package Version --> |
65 | <td>{%if package.version%}<a href="{% url "package_built_detail" build.pk package.pk %}">{{package.version}}-{{package.revision}}</a>{%endif%}</td> | 65 | <td>{%if package.version%}<a href="{% url "package_built_detail" build.pk package.pk %}">{{package.version}}-{{package.revision}}</a>{%endif%}</td> |
66 | <!-- Package Size --> | 66 | <!-- Package Size --> |
67 | <td class="size">{{package.size|filtered_filesizeformat}}</td> | 67 | <td class="size sizecol">{{package.size|filtered_filesizeformat}}</td> |
68 | <!-- License --> | 68 | <!-- License --> |
69 | <td class="license">{{package.license}}</td> | 69 | <td class="license">{{package.license}}</td> |
70 | 70 | ||