summaryrefslogtreecommitdiffstats
path: root/bitbake/lib/toaster/bldcontrol/bbcontroller.py
diff options
context:
space:
mode:
authorAlexandru DAMIAN <alexandru.damian@intel.com>2014-10-13 17:10:39 +0100
committerRichard Purdie <richard.purdie@linuxfoundation.org>2014-10-30 13:39:51 +0000
commit2837b110ae8fd5ff0ca3ac5959cadb7d4a5ce6cc (patch)
treefca7aba2e90cbcb6f3b11a90bb00665850fa2460 /bitbake/lib/toaster/bldcontrol/bbcontroller.py
parenta0660718e6599538dd65cadadbc04c6adc951b57 (diff)
downloadpoky-2837b110ae8fd5ff0ca3ac5959cadb7d4a5ce6cc.tar.gz
bitbake: toaster: change startup parameter passing to avoid race
We avoid a race between the setting the TOASTER_BRBE variable and reading the variable in toaster ui by supplying the variable at server startup time through the toaster.conf post-read file. Additional small changes are included, including marking the build request with the environment id of where the build took place. (Bitbake rev: 7c333350418c4140e6c988c5272940f8057d327d) Signed-off-by: Alexandru DAMIAN <alexandru.damian@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Diffstat (limited to 'bitbake/lib/toaster/bldcontrol/bbcontroller.py')
-rw-r--r--bitbake/lib/toaster/bldcontrol/bbcontroller.py6
1 files changed, 3 insertions, 3 deletions
diff --git a/bitbake/lib/toaster/bldcontrol/bbcontroller.py b/bitbake/lib/toaster/bldcontrol/bbcontroller.py
index 6812ae3e6e..6bb45d6388 100644
--- a/bitbake/lib/toaster/bldcontrol/bbcontroller.py
+++ b/bitbake/lib/toaster/bldcontrol/bbcontroller.py
@@ -118,7 +118,7 @@ class BuildEnvironmentController(object):
118 self.connection = None 118 self.connection = None
119 119
120 120
121 def startBBServer(self): 121 def startBBServer(self, brbe):
122 """ Starts a BB server with Toaster toasterui set up to record the builds, an no controlling UI. 122 """ Starts a BB server with Toaster toasterui set up to record the builds, an no controlling UI.
123 After this method executes, self.be bbaddress/bbport MUST point to a running and free server, 123 After this method executes, self.be bbaddress/bbport MUST point to a running and free server,
124 and the bbstate MUST be updated to "started". 124 and the bbstate MUST be updated to "started".
@@ -142,12 +142,12 @@ class BuildEnvironmentController(object):
142 raise Exception("Must override setLayers") 142 raise Exception("Must override setLayers")
143 143
144 144
145 def getBBController(self): 145 def getBBController(self, brbe):
146 """ returns a BitbakeController to an already started server; this is the point where the server 146 """ returns a BitbakeController to an already started server; this is the point where the server
147 starts if needed; or reconnects to the server if we can 147 starts if needed; or reconnects to the server if we can
148 """ 148 """
149 if not self.connection: 149 if not self.connection:
150 self.startBBServer() 150 self.startBBServer(brbe)
151 self.be.lock = BuildEnvironment.LOCK_RUNNING 151 self.be.lock = BuildEnvironment.LOCK_RUNNING
152 self.be.save() 152 self.be.save()
153 153