diff options
author | Mark Hatle <mark.hatle@windriver.com> | 2019-03-12 18:46:21 -0400 |
---|---|---|
committer | Richard Purdie <richard.purdie@linuxfoundation.org> | 2019-03-24 16:42:22 +0000 |
commit | 7d9f83731f9cecd76068e4cbb7000655380393c9 (patch) | |
tree | d6c14327b49031ece8742da2a47d794b68e0bf83 /bitbake/lib/bs4/dammit.py | |
parent | 2570de58a08d521e6ab2692c2c3d3c400f1651a0 (diff) | |
download | poky-7d9f83731f9cecd76068e4cbb7000655380393c9.tar.gz |
bitbake: gitsm.py: Optimize code and attempt to resolve locking issue
It was reported that a race condition on a shared download directory could
occur with the gitsm fetcher, the result happened with a call to
git config
that occured within the update_submodules. Since the fetch is locked by the
upper level, it was probably the prior need_update(...) function causing this
because of some old code.
The gitsm class inherits the git class. The need_update was overridding the
version in gitsm, so that it forceably checked the submodules.
It's clear we can optimize the code by only updating if the primary repository
needs updating. Since we don't care if the submodule repository has changed
because if the primary hasn't, references to the submodule won't change.
(Bitbake rev: 4660933f83e528766d71eab662cc79dcf17b4be7)
Signed-off-by: Mark Hatle <mark.hatle@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
(cherry picked from commit 346338667edca1f58ace769ad417548da2b8d981)
Signed-off-by: Scott Murray <scott.murray@konsulko.com>
Signed-off-by: Armin Kuster <akuster@mvista.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Diffstat (limited to 'bitbake/lib/bs4/dammit.py')
0 files changed, 0 insertions, 0 deletions