diff options
author | Ed Bartosh <eduard.bartosh@intel.com> | 2016-06-10 14:58:17 +0300 |
---|---|---|
committer | Richard Purdie <richard.purdie@linuxfoundation.org> | 2016-06-16 11:51:26 +0100 |
commit | 772e9b4eabf054cadb8ad2dc6b223aa6c30c7f46 (patch) | |
tree | 9e2c544940f461e35cc642584388fb35c7a04d1c /bitbake/lib/bb/ui | |
parent | 39ed5441c58daedddca8dfaee1d310f5c62337e6 (diff) | |
download | poky-772e9b4eabf054cadb8ad2dc6b223aa6c30c7f46.tar.gz |
bitbake: bitbake: fix wrong usage of format_exc
First parameter of traceback.format_exc is a 'limit' - a number
of stracktraces to format.
Passing exception object to format_exc is incorrect, but it works in
Python 2 as this code from traceback module works:
while tb is not None and (limit is None or n < limit):
Comparing integer counter n with the exception object in Python 2
always results in True. However, in Python 3 it throws exception:
TypeError: unorderable types: int() < <Exception type>()
As format_exc is used in except block of handling another
exception this can cause hard to find and debug bugs.
(Bitbake rev: a9509949d7e2adba6e3cd89f97daa19a955855b5)
Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Diffstat (limited to 'bitbake/lib/bb/ui')
-rw-r--r-- | bitbake/lib/bb/ui/uievent.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/bitbake/lib/bb/ui/uievent.py b/bitbake/lib/bb/ui/uievent.py index ca1916664d..9542b911ca 100644 --- a/bitbake/lib/bb/ui/uievent.py +++ b/bitbake/lib/bb/ui/uievent.py | |||
@@ -116,7 +116,7 @@ class BBUIEventQueue: | |||
116 | self.server.handle_request() | 116 | self.server.handle_request() |
117 | except Exception as e: | 117 | except Exception as e: |
118 | import traceback | 118 | import traceback |
119 | logger.error("BBUIEventQueue.startCallbackHandler: Exception while trying to handle request: %s\n%s" % (e, traceback.format_exc(e))) | 119 | logger.error("BBUIEventQueue.startCallbackHandler: Exception while trying to handle request: %s\n%s" % (e, traceback.format_exc())) |
120 | 120 | ||
121 | self.server.server_close() | 121 | self.server.server_close() |
122 | 122 | ||