diff options
author | Robert Yang <liezhi.yang@windriver.com> | 2012-05-20 20:36:05 +0800 |
---|---|---|
committer | Richard Purdie <richard.purdie@linuxfoundation.org> | 2012-05-23 11:35:11 +0100 |
commit | 10a0f9ed929449543e5caab7e5f8855e0e68605b (patch) | |
tree | 906283ad2b35380b2240854f120eb646f51c8fab /bitbake/lib/bb/ui/ncurses.py | |
parent | 358016f463958640c694d031a481264a0e770802 (diff) | |
download | poky-10a0f9ed929449543e5caab7e5f8855e0e68605b.tar.gz |
replace os.system with subprocess.call
Replace os.system with subprocess.call since the older function would
fail (more or less) silently if the executed program cannot be found
More info:
http://docs.python.org/library/subprocess.html#subprocess-replacements
[YOCTO #2075]
(Bitbake rev: f5b3bf115dc1ffbfb241a49cec0fc3654cb71021)
Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Diffstat (limited to 'bitbake/lib/bb/ui/ncurses.py')
-rw-r--r-- | bitbake/lib/bb/ui/ncurses.py | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/bitbake/lib/bb/ui/ncurses.py b/bitbake/lib/bb/ui/ncurses.py index 8524446d22..1425bbd263 100644 --- a/bitbake/lib/bb/ui/ncurses.py +++ b/bitbake/lib/bb/ui/ncurses.py | |||
@@ -47,7 +47,7 @@ | |||
47 | 47 | ||
48 | from __future__ import division | 48 | from __future__ import division |
49 | import logging | 49 | import logging |
50 | import os, sys, curses, itertools, time | 50 | import os, sys, curses, itertools, time, subprocess |
51 | import bb | 51 | import bb |
52 | import xmlrpclib | 52 | import xmlrpclib |
53 | from bb import ui | 53 | from bb import ui |
@@ -286,7 +286,7 @@ class NCursesUI: | |||
286 | # bb.error("log data follows (%s)" % logfile) | 286 | # bb.error("log data follows (%s)" % logfile) |
287 | # number_of_lines = data.getVar("BBINCLUDELOGS_LINES", d) | 287 | # number_of_lines = data.getVar("BBINCLUDELOGS_LINES", d) |
288 | # if number_of_lines: | 288 | # if number_of_lines: |
289 | # os.system('tail -n%s %s' % (number_of_lines, logfile)) | 289 | # subprocess.call('tail -n%s %s' % (number_of_lines, logfile), shell=True) |
290 | # else: | 290 | # else: |
291 | # f = open(logfile, "r") | 291 | # f = open(logfile, "r") |
292 | # while True: | 292 | # while True: |