summaryrefslogtreecommitdiffstats
path: root/bitbake/lib/bb/ui/knotty.py
diff options
context:
space:
mode:
authorRichard Purdie <richard.purdie@linuxfoundation.org>2011-08-12 23:24:43 +0100
committerRichard Purdie <richard.purdie@linuxfoundation.org>2011-08-15 09:14:28 +0100
commit7ee93b206a6389e6eb7b9440dc2fae801c77bc9b (patch)
tree6700acff792125542187590c5633c61c29b1005b /bitbake/lib/bb/ui/knotty.py
parentfce0b963b437c5b0660dca6f5b0a099e4befa03c (diff)
downloadpoky-7ee93b206a6389e6eb7b9440dc2fae801c77bc9b.tar.gz
bitbake/logging: Overhaul internal logging process
At the moment it bugs me a lot that we only have one effective logging level for bitbake, despite the logging module having provision to do more advanced things. This patch: * Changes the core log level to the lowest level we have messages of (DEBUG-2) so messages always flow through the core logger * Allows build.py's task logging code to log all the output regardless of what output is on the console and sets this so log files now always contain debug level messages even if these don't appear on the console * Moves the verbose/debug/debug-domains code to be a UI side setting * Adds a filter to the UI to only print the user requested output. The result is more complete logfiles on disk but the usual output to the console. There are some behaviour changes intentionally made by this patch: a) the -v option now controls whether output is tee'd to the console. Ultimately, we likely want to output a message to the user about where the log file is and avoid placing output directly onto the console for every executing task. b) The functions get_debug_levels, the debug_levels variable, the set_debug_levels, the set_verbosity and set_debug_domains functions are removed from bb.msg. c) The "logging" init function changes format. d) All messages get fired to all handlers all the time leading to an increase in inter-process traffic. This could likely be hacked around short term with a function for a UI to only request events greater than level X. Longer term, having masks for event handlers would be better. e) logger.getEffectiveLevel() is no longer a reliable guide to what will/won't get logged so for now we look at the default log levels instead. [YOCTO #304] (Bitbake rev: 45aad2f9647df14bcfa5e755b57e1ddab377939a) Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Diffstat (limited to 'bitbake/lib/bb/ui/knotty.py')
-rw-r--r--bitbake/lib/bb/ui/knotty.py5
1 files changed, 3 insertions, 2 deletions
diff --git a/bitbake/lib/bb/ui/knotty.py b/bitbake/lib/bb/ui/knotty.py
index 7a2681d2bf..7c645adcc4 100644
--- a/bitbake/lib/bb/ui/knotty.py
+++ b/bitbake/lib/bb/ui/knotty.py
@@ -74,6 +74,7 @@ def main(server, eventHandler):
74 74
75 console = logging.StreamHandler(sys.stdout) 75 console = logging.StreamHandler(sys.stdout)
76 format = bb.msg.BBLogFormatter("%(levelname)s: %(message)s") 76 format = bb.msg.BBLogFormatter("%(levelname)s: %(message)s")
77 bb.msg.addDefaultlogFilter(console)
77 console.setFormatter(format) 78 console.setFormatter(format)
78 logger.addHandler(console) 79 logger.addHandler(console)
79 80
@@ -120,8 +121,8 @@ def main(server, eventHandler):
120 # For "normal" logging conditions, don't show note logs from tasks 121 # For "normal" logging conditions, don't show note logs from tasks
121 # but do show them if the user has changed the default log level to 122 # but do show them if the user has changed the default log level to
122 # include verbose/debug messages 123 # include verbose/debug messages
123 if logger.getEffectiveLevel() > format.VERBOSE: 124 #if logger.getEffectiveLevel() > format.VERBOSE:
124 if event.taskpid != 0 and event.levelno <= format.NOTE: 125 if event.taskpid != 0 and event.levelno <= format.NOTE:
125 continue 126 continue
126 logger.handle(event) 127 logger.handle(event)
127 continue 128 continue