diff options
author | Joshua Lock <josh@linux.intel.com> | 2011-07-26 17:44:34 -0700 |
---|---|---|
committer | Richard Purdie <richard.purdie@linuxfoundation.org> | 2011-07-27 16:54:04 +0100 |
commit | b004d8ef0f06cbf302a55b73b20b7ee7dac645f7 (patch) | |
tree | c6b2d4754452d43abcb469b443d5c0f428cd57a1 /bitbake/lib/bb/ui/hob.py | |
parent | 6b109860bfa093b7f1fe7ddae2e60595d070735b (diff) | |
download | poky-b004d8ef0f06cbf302a55b73b20b7ee7dac645f7.tar.gz |
hob: fix loading customised image recipe
The signal handler of the 'Base image' combo was still connected during load
such that updating the UI to reflect the loaded base image triggered a change
of the model. Fix this by disconnecting the signal handler when updating the
displayed 'Base image'.
Fixes [YOCTO #1282]
(Bitbake rev: 58036a79cb79d1dff307e2cfed0e684493178507)
Signed-off-by: Joshua Lock <josh@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Diffstat (limited to 'bitbake/lib/bb/ui/hob.py')
-rw-r--r-- | bitbake/lib/bb/ui/hob.py | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/bitbake/lib/bb/ui/hob.py b/bitbake/lib/bb/ui/hob.py index d3442c518c..90d5c5aa90 100644 --- a/bitbake/lib/bb/ui/hob.py +++ b/bitbake/lib/bb/ui/hob.py | |||
@@ -122,6 +122,10 @@ class MainWindow (gtk.Window): | |||
122 | self.build_succeeded = False | 122 | self.build_succeeded = False |
123 | 123 | ||
124 | def image_changed_string_cb(self, model, new_image): | 124 | def image_changed_string_cb(self, model, new_image): |
125 | # disconnect the image combo's signal handler | ||
126 | if self.image_combo_id: | ||
127 | self.image_combo.disconnect(self.image_combo_id) | ||
128 | self.image_combo_id = None | ||
125 | cnt = 0 | 129 | cnt = 0 |
126 | it = self.model.images.get_iter_first() | 130 | it = self.model.images.get_iter_first() |
127 | while it: | 131 | while it: |
@@ -131,6 +135,8 @@ class MainWindow (gtk.Window): | |||
131 | break | 135 | break |
132 | it = self.model.images.iter_next(it) | 136 | it = self.model.images.iter_next(it) |
133 | cnt = cnt + 1 | 137 | cnt = cnt + 1 |
138 | # Reconnect the signal handler | ||
139 | self.image_combo_id = self.image_combo.connect("changed", self.image_changed_cb) | ||
134 | 140 | ||
135 | def image_changed_cb(self, combo): | 141 | def image_changed_cb(self, combo): |
136 | model = self.image_combo.get_model() | 142 | model = self.image_combo.get_model() |