diff options
author | Shane Wang <shane.wang@intel.com> | 2012-03-16 13:40:41 +0800 |
---|---|---|
committer | Richard Purdie <richard.purdie@linuxfoundation.org> | 2012-03-20 15:21:33 +0000 |
commit | 9ecdbc377c6ab6848afb0a378c5804918951f6b7 (patch) | |
tree | 6a399868e8e832298e94bd8a03eaf0b7728b7950 /bitbake/lib/bb/ui/crumbs/packageselectionpage.py | |
parent | dab638e150fb2af56f54f0752383965b016f4960 (diff) | |
download | poky-9ecdbc377c6ab6848afb0a378c5804918951f6b7.tar.gz |
Hob: change the code style to enumerate a list in a for-loop
We use the more common style to enumerate a list in a for-loop
(http://docs.python.org/library/functions.html#enumerate), that is:
try to use
for item in mylist,
and try to use
for i, item in enumerate(list)
rather than
for i in range(len(mylist))
(From Poky rev: 33c21bc60bd1542f81d33c328f116dec424728cd)
(Bitbake rev: 9b168239a5d9693573438eb6514938b81de85af3)
Signed-off-by: Shane Wang <shane.wang@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Diffstat (limited to 'bitbake/lib/bb/ui/crumbs/packageselectionpage.py')
-rwxr-xr-x | bitbake/lib/bb/ui/crumbs/packageselectionpage.py | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/bitbake/lib/bb/ui/crumbs/packageselectionpage.py b/bitbake/lib/bb/ui/crumbs/packageselectionpage.py index 3cd1c5e725..23e460caa0 100755 --- a/bitbake/lib/bb/ui/crumbs/packageselectionpage.py +++ b/bitbake/lib/bb/ui/crumbs/packageselectionpage.py | |||
@@ -105,16 +105,16 @@ class PackageSelectionPage (HobPage): | |||
105 | self.ins = HobNotebook() | 105 | self.ins = HobNotebook() |
106 | self.tables = [] # we need to modify table when the dialog is shown | 106 | self.tables = [] # we need to modify table when the dialog is shown |
107 | # append the tab | 107 | # append the tab |
108 | for i in range(len(self.pages)): | 108 | for page in self.pages: |
109 | columns = self.pages[i]['columns'] | 109 | columns = page['columns'] |
110 | tab = HobViewTable(columns) | 110 | tab = HobViewTable(columns) |
111 | filter = self.pages[i]['filter'] | 111 | filter = page['filter'] |
112 | tab.set_model(self.package_model.tree_model(filter)) | 112 | tab.set_model(self.package_model.tree_model(filter)) |
113 | tab.connect("toggled", self.table_toggled_cb) | 113 | tab.connect("toggled", self.table_toggled_cb) |
114 | if self.pages[i]['name'] == "Included": | 114 | if page['name'] == "Included": |
115 | tab.connect("row-activated", self.tree_row_activated_cb) | 115 | tab.connect("row-activated", self.tree_row_activated_cb) |
116 | 116 | ||
117 | label = gtk.Label(self.pages[i]['name']) | 117 | label = gtk.Label(page['name']) |
118 | self.ins.append_page(tab, label) | 118 | self.ins.append_page(tab, label) |
119 | self.tables.append(tab) | 119 | self.tables.append(tab) |
120 | 120 | ||