diff options
author | Cristian Iorga <cristian.iorga@intel.com> | 2012-09-28 18:05:53 +0300 |
---|---|---|
committer | Richard Purdie <richard.purdie@linuxfoundation.org> | 2012-09-28 16:42:09 +0100 |
commit | 183ffd2048a1ff864a2c32412c4f8b409ee4c3e9 (patch) | |
tree | 4c9197280b8632a73dac693475b1512f5734fdf7 /bitbake/lib/bb/ui/crumbs/builder.py | |
parent | 1a85fc8f5b9d04fecb87ecc04ac89b52387090a1 (diff) | |
download | poky-183ffd2048a1ff864a2c32412c4f8b409ee4c3e9.tar.gz |
bitbake: hob: Error reports are done in a clearer way
For long errors (bigger than 200 letters),
the text box is scrollable and resizable
and text is selectable.
Additionaly, all message dialogs are modal.
Otherwise, a user could still interact with hob
even in an error case, leading to potential problems.
See design details in related bugs.
Fixes [YOCTO #2960], [YOCTO #2983]
(Bitbake rev: be8bf02f2b347edf5514cafc6cb6a44f71118736)
Signed-off-by: Cristian Iorga <cristian.iorga@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Diffstat (limited to 'bitbake/lib/bb/ui/crumbs/builder.py')
-rwxr-xr-x | bitbake/lib/bb/ui/crumbs/builder.py | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/bitbake/lib/bb/ui/crumbs/builder.py b/bitbake/lib/bb/ui/crumbs/builder.py index e952aa8208..fd555b0e7c 100755 --- a/bitbake/lib/bb/ui/crumbs/builder.py +++ b/bitbake/lib/bb/ui/crumbs/builder.py | |||
@@ -849,9 +849,8 @@ class Builder(gtk.Window): | |||
849 | self.generate_image_async(True) | 849 | self.generate_image_async(True) |
850 | 850 | ||
851 | def show_error_dialog(self, msg): | 851 | def show_error_dialog(self, msg): |
852 | lbl = "<b>Error</b>\n" | 852 | lbl = "<b>Hob found an error</b>\n" |
853 | lbl = lbl + "%s\n\n" % glib.markup_escape_text(msg) | 853 | dialog = CrumbsMessageDialog(self, lbl, gtk.STOCK_DIALOG_ERROR, msg) |
854 | dialog = CrumbsMessageDialog(self, lbl, gtk.STOCK_DIALOG_ERROR) | ||
855 | button = dialog.add_button("Close", gtk.RESPONSE_OK) | 854 | button = dialog.add_button("Close", gtk.RESPONSE_OK) |
856 | HobButton.style_button(button) | 855 | HobButton.style_button(button) |
857 | response = dialog.run() | 856 | response = dialog.run() |