summaryrefslogtreecommitdiffstats
path: root/bitbake/lib/bb/runqueue.py
diff options
context:
space:
mode:
authorRichard Purdie <richard.purdie@linuxfoundation.org>2016-12-15 09:36:30 +0000
committerRichard Purdie <richard.purdie@linuxfoundation.org>2016-12-16 10:23:24 +0000
commit2c4e366721a0571a2052a23fb0d7e4bbeae552bc (patch)
tree8051c6ac5036c93d0e55513f73dc8becb5b89abc /bitbake/lib/bb/runqueue.py
parent97f83e911ebb2c9d1af5de55a94c994dced39d82 (diff)
downloadpoky-2c4e366721a0571a2052a23fb0d7e4bbeae552bc.tar.gz
bitbake: cooker/command: Drop expanded_data
Some of our metadata assumes that BuildStarted and BuildCompleted events see the same data store. This is the case for buildTarget but not for buildFile and recent changes mean this is now a problem. The update_data() call is now an empty operation and there is no difference between the expanded_data and data so we can simply remove the expanded_data and its references and use data everywhere. This has been inteded for a while but the above issue makes this more pressing to finally clean up. (Bitbake rev: e3694e738e98f26f413ada6860ca7d829d3662f0) Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Diffstat (limited to 'bitbake/lib/bb/runqueue.py')
-rw-r--r--bitbake/lib/bb/runqueue.py8
1 files changed, 4 insertions, 4 deletions
diff --git a/bitbake/lib/bb/runqueue.py b/bitbake/lib/bb/runqueue.py
index 2ad8aad98e..da7502118a 100644
--- a/bitbake/lib/bb/runqueue.py
+++ b/bitbake/lib/bb/runqueue.py
@@ -1341,7 +1341,7 @@ class RunQueue:
1341 sq_hash.append(self.rqdata.runtaskentries[tid].hash) 1341 sq_hash.append(self.rqdata.runtaskentries[tid].hash)
1342 sq_taskname.append(taskname) 1342 sq_taskname.append(taskname)
1343 sq_task.append(tid) 1343 sq_task.append(tid)
1344 locs = { "sq_fn" : sq_fn, "sq_task" : sq_taskname, "sq_hash" : sq_hash, "sq_hashfn" : sq_hashfn, "d" : self.cooker.expanded_data } 1344 locs = { "sq_fn" : sq_fn, "sq_task" : sq_taskname, "sq_hash" : sq_hash, "sq_hashfn" : sq_hashfn, "d" : self.cooker.data }
1345 try: 1345 try:
1346 call = self.hashvalidate + "(sq_fn, sq_task, sq_hash, sq_hashfn, d, siginfo=True)" 1346 call = self.hashvalidate + "(sq_fn, sq_task, sq_hash, sq_hashfn, d, siginfo=True)"
1347 valid = bb.utils.better_eval(call, locs) 1347 valid = bb.utils.better_eval(call, locs)
@@ -1525,7 +1525,7 @@ class RunQueueExecute:
1525 pn = self.rqdata.dataCaches[mc].pkg_fn[fn] 1525 pn = self.rqdata.dataCaches[mc].pkg_fn[fn]
1526 taskdata[dep] = [pn, taskname, fn] 1526 taskdata[dep] = [pn, taskname, fn]
1527 call = self.rq.depvalidate + "(task, taskdata, notneeded, d)" 1527 call = self.rq.depvalidate + "(task, taskdata, notneeded, d)"
1528 locs = { "task" : task, "taskdata" : taskdata, "notneeded" : self.scenequeue_notneeded, "d" : self.cooker.expanded_data } 1528 locs = { "task" : task, "taskdata" : taskdata, "notneeded" : self.scenequeue_notneeded, "d" : self.cooker.data }
1529 valid = bb.utils.better_eval(call, locs) 1529 valid = bb.utils.better_eval(call, locs)
1530 return valid 1530 return valid
1531 1531
@@ -1593,7 +1593,7 @@ class RunQueueExecuteTasks(RunQueueExecute):
1593 invalidtasks.append(tid) 1593 invalidtasks.append(tid)
1594 1594
1595 call = self.rq.setsceneverify + "(covered, tasknames, fns, d, invalidtasks=invalidtasks)" 1595 call = self.rq.setsceneverify + "(covered, tasknames, fns, d, invalidtasks=invalidtasks)"
1596 locs = { "covered" : self.rq.scenequeue_covered, "tasknames" : tasknames, "fns" : fns, "d" : self.cooker.expanded_data, "invalidtasks" : invalidtasks } 1596 locs = { "covered" : self.rq.scenequeue_covered, "tasknames" : tasknames, "fns" : fns, "d" : self.cooker.data, "invalidtasks" : invalidtasks }
1597 covered_remove = bb.utils.better_eval(call, locs) 1597 covered_remove = bb.utils.better_eval(call, locs)
1598 1598
1599 def removecoveredtask(tid): 1599 def removecoveredtask(tid):
@@ -2086,7 +2086,7 @@ class RunQueueExecuteScenequeue(RunQueueExecute):
2086 sq_taskname.append(taskname) 2086 sq_taskname.append(taskname)
2087 sq_task.append(tid) 2087 sq_task.append(tid)
2088 call = self.rq.hashvalidate + "(sq_fn, sq_task, sq_hash, sq_hashfn, d)" 2088 call = self.rq.hashvalidate + "(sq_fn, sq_task, sq_hash, sq_hashfn, d)"
2089 locs = { "sq_fn" : sq_fn, "sq_task" : sq_taskname, "sq_hash" : sq_hash, "sq_hashfn" : sq_hashfn, "d" : self.cooker.expanded_data } 2089 locs = { "sq_fn" : sq_fn, "sq_task" : sq_taskname, "sq_hash" : sq_hash, "sq_hashfn" : sq_hashfn, "d" : self.cooker.data }
2090 valid = bb.utils.better_eval(call, locs) 2090 valid = bb.utils.better_eval(call, locs)
2091 2091
2092 valid_new = stamppresent 2092 valid_new = stamppresent