diff options
author | Richard Purdie <richard.purdie@linuxfoundation.org> | 2014-03-09 17:55:45 -0700 |
---|---|---|
committer | Richard Purdie <richard.purdie@linuxfoundation.org> | 2014-03-10 11:10:00 -0700 |
commit | aadfea6be629a17e4e26747aba4f59f5ac8e7558 (patch) | |
tree | b9491516757b2243b56b1b7b1cbf7e06770f435e /bitbake/lib/bb/providers.py | |
parent | 0b4ae1c7742cec14395a0d845e1ed42b88b0e215 (diff) | |
download | poky-aadfea6be629a17e4e26747aba4f59f5ac8e7558.tar.gz |
bitbake: providers/runqueue/taskdata: Optimise logger.debug calls
A run of "bitbake bash -c unpack" when the task has already been
completed resulted in about 9000 calls to logger.debug(). With this
patch which comments out some noisy/less usefull logging and moves
other logging calls outside loops, this number is reduced to 1000
calls. This results in cleaner logs and gives a small but
measurable 0.15s speedup. The log size dropped from 900kb to 160kb.
(Bitbake rev: d2677f084fe1d8846db77d89ef5e6ffb18dc171a)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Diffstat (limited to 'bitbake/lib/bb/providers.py')
-rw-r--r-- | bitbake/lib/bb/providers.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/bitbake/lib/bb/providers.py b/bitbake/lib/bb/providers.py index 3a4f6040a5..637e1fab96 100644 --- a/bitbake/lib/bb/providers.py +++ b/bitbake/lib/bb/providers.py | |||
@@ -325,7 +325,7 @@ def filterProvidersRunTime(providers, item, cfgData, dataCache): | |||
325 | provides = dataCache.pn_provides[pn] | 325 | provides = dataCache.pn_provides[pn] |
326 | for provide in provides: | 326 | for provide in provides: |
327 | prefervar = cfgData.getVar('PREFERRED_PROVIDER_%s' % provide, True) | 327 | prefervar = cfgData.getVar('PREFERRED_PROVIDER_%s' % provide, True) |
328 | logger.debug(1, "checking PREFERRED_PROVIDER_%s (value %s) against %s", provide, prefervar, pns.keys()) | 328 | #logger.debug(1, "checking PREFERRED_PROVIDER_%s (value %s) against %s", provide, prefervar, pns.keys()) |
329 | if prefervar in pns and pns[prefervar] not in preferred: | 329 | if prefervar in pns and pns[prefervar] not in preferred: |
330 | var = "PREFERRED_PROVIDER_%s = %s" % (provide, prefervar) | 330 | var = "PREFERRED_PROVIDER_%s = %s" % (provide, prefervar) |
331 | logger.verbose("selecting %s to satisfy runtime %s due to %s", prefervar, item, var) | 331 | logger.verbose("selecting %s to satisfy runtime %s due to %s", prefervar, item, var) |