diff options
author | Chris Larson <chris_larson@mentor.com> | 2010-09-09 18:03:40 -0700 |
---|---|---|
committer | Richard Purdie <rpurdie@linux.intel.com> | 2011-01-04 14:46:35 +0000 |
commit | 9897d56861a3894e34bf77a62255dc57e680a18e (patch) | |
tree | c9ac420fedf434e693d364d70380fe1b9475bd86 /bitbake/lib/bb/cooker.py | |
parent | 1e7204a7b5b7b9a73759646fa0e297c7b4bc55ed (diff) | |
download | poky-9897d56861a3894e34bf77a62255dc57e680a18e.tar.gz |
Simplify build exception handling
- Drop EventException
- Use FuncFailed as the primary function failure exception, using TaskFailed
for the event (leaving it up to the process running exec_{func,task} to
display the more detailed information available in the exception).
- Switch InvalidTask to an exception rather than an event, as that's a
critical issue.
- Reduce the number of messages shown to the user when a task fails -- they
don't need to be told it fails 12 times. Work remains in this area though.
(Bitbake rev: 06b742aae2b8013cbb269cc30554cff89e3a5667)
Signed-off-by: Chris Larson <chris_larson@mentor.com>
Signed-off-by: Richard Purdie <rpurdie@linux.intel.com>
Diffstat (limited to 'bitbake/lib/bb/cooker.py')
-rw-r--r-- | bitbake/lib/bb/cooker.py | 8 |
1 files changed, 2 insertions, 6 deletions
diff --git a/bitbake/lib/bb/cooker.py b/bitbake/lib/bb/cooker.py index de213f03f4..c1e2105c5e 100644 --- a/bitbake/lib/bb/cooker.py +++ b/bitbake/lib/bb/cooker.py | |||
@@ -690,9 +690,7 @@ class BBCooker: | |||
690 | try: | 690 | try: |
691 | retval = rq.execute_runqueue() | 691 | retval = rq.execute_runqueue() |
692 | except runqueue.TaskFailure as exc: | 692 | except runqueue.TaskFailure as exc: |
693 | for fnid in exc.args: | 693 | failures += len(exc.args) |
694 | buildlog.error("'%s' failed" % taskdata.fn_index[fnid]) | ||
695 | failures = failures + 1 | ||
696 | retval = False | 694 | retval = False |
697 | if not retval: | 695 | if not retval: |
698 | bb.event.fire(bb.event.BuildCompleted(buildname, item, failures), self.configuration.event_data) | 696 | bb.event.fire(bb.event.BuildCompleted(buildname, item, failures), self.configuration.event_data) |
@@ -727,9 +725,7 @@ class BBCooker: | |||
727 | try: | 725 | try: |
728 | retval = rq.execute_runqueue() | 726 | retval = rq.execute_runqueue() |
729 | except runqueue.TaskFailure as exc: | 727 | except runqueue.TaskFailure as exc: |
730 | for fnid in exc.args: | 728 | failures += len(exc.args) |
731 | buildlog.error("'%s' failed" % taskdata.fn_index[fnid]) | ||
732 | failures = failures + 1 | ||
733 | retval = False | 729 | retval = False |
734 | if not retval: | 730 | if not retval: |
735 | bb.event.fire(bb.event.BuildCompleted(buildname, targets, failures), self.configuration.event_data) | 731 | bb.event.fire(bb.event.BuildCompleted(buildname, targets, failures), self.configuration.event_data) |