bitbake: lib/bb: Update thread/process locks to use a timeout

The thread/process locks we use translate to futexes in Linux. If a
process dies holding the lock, anything else trying to take the lock
will hang indefinitely. An example would be the OOM killer taking out
a parser process.

To avoid bitbake processes just hanging indefinitely, add a timeout to
our lock calls using a context manager. If we can't obtain the lock
after waiting 5 minutes, hard exit out using os._exit(1). Use _exit()
to avoid locking in any other places trying to write error messages to
event handler queues (which also need locks).

Whilst a bit harsh, this should mean we stop having lots of long running
processes in cases where things are never going to work out and also
avoids hanging builds on the autobuilder.

(Bitbake rev: d2a3f662b0eed900fc012a392bfa0a365df0df9b)

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>

1 files changed, 2 insertions, 2 deletions

diff --git a/bitbake/lib/bb/cooker.py b/bitbake/lib/bb/cooker.py
index a5a635858c..738849d189 100644
--- a/bitbake/lib/bb/cooker.py
+++ b/bitbake/lib/bb/cooker.py
@@ -251,14 +251,14 @@ class BBCooker:
         self.notifier = pyinotify.Notifier(self.watcher, self.notifications)
 
     def process_inotify_updates(self):
-        with self.inotify_threadlock:
+        with bb.utils.lock_timeout(self.inotify_threadlock):
             for n in [self.confignotifier, self.notifier]:
                 if n and n.check_events(timeout=0):
                     # read notified events and enqueue them
                     n.read_events()
 
     def process_inotify_updates_apply(self):
-        with self.inotify_threadlock:
+        with bb.utils.lock_timeout(self.inotify_threadlock):
             for n in [self.confignotifier, self.notifier]:
                 if n and n.check_events(timeout=0):
                     n.read_events()