diff options
author | Richard Purdie <richard.purdie@linuxfoundation.org> | 2012-01-09 17:01:51 +0000 |
---|---|---|
committer | Richard Purdie <richard.purdie@linuxfoundation.org> | 2012-01-10 17:40:43 +0000 |
commit | a5463088fe57462bf681b648d21212808454fc2a (patch) | |
tree | e3412641a6d15ef93b55f06e14ff51c45fef402e /bitbake/lib/bb/command.py | |
parent | e4a365098a9550facae9af069d4b58770dabfd91 (diff) | |
download | poky-a5463088fe57462bf681b648d21212808454fc2a.tar.gz |
bitbake: Add BBHandledException exception class
We have a problem knowing when to show the user debug information and
when not to since the code has already shown the user suitable information
about why a failure is occurring.
This patch adds a bb.BBHandledException exception class which can be used
to identify those exceptions which don't need further explanation to
the user.
This patch uses this class for the bb.providers exceptions and ensures the
command handling code correctly filters the exceptions meaning that
"bitbake invalid"
now shows an simple error message and not a python traceback.
[YOCTO #1141 partial]
(Bitbake rev: eac9249b40ae1e3aa21e016010c862664e59a8d4)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Diffstat (limited to 'bitbake/lib/bb/command.py')
-rw-r--r-- | bitbake/lib/bb/command.py | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/bitbake/lib/bb/command.py b/bitbake/lib/bb/command.py index f236daceb1..2a3a3afaca 100644 --- a/bitbake/lib/bb/command.py +++ b/bitbake/lib/bb/command.py | |||
@@ -98,9 +98,12 @@ class Command: | |||
98 | else: | 98 | else: |
99 | self.finishAsyncCommand("Exited with %s" % arg) | 99 | self.finishAsyncCommand("Exited with %s" % arg) |
100 | return False | 100 | return False |
101 | except Exception: | 101 | except Exception as exc: |
102 | import traceback | 102 | import traceback |
103 | self.finishAsyncCommand(traceback.format_exc()) | 103 | if isinstance(exc, bb.BBHandledException): |
104 | self.finishAsyncCommand("") | ||
105 | else: | ||
106 | self.finishAsyncCommand(traceback.format_exc()) | ||
104 | return False | 107 | return False |
105 | 108 | ||
106 | def finishAsyncCommand(self, msg=None, code=None): | 109 | def finishAsyncCommand(self, msg=None, code=None): |