diff options
author | Ross Burton <ross.burton@intel.com> | 2017-09-13 10:58:09 +0100 |
---|---|---|
committer | Richard Purdie <richard.purdie@linuxfoundation.org> | 2017-09-13 22:07:42 +0100 |
commit | 07a1ca3e81c04b26fbe07b634da6eb794412e36e (patch) | |
tree | fb6e1e0f115c74d083165f696effafda22687dff | |
parent | 03634c1d0ceb4cd0c90097b43ca5d17a74e1f0cc (diff) | |
download | poky-07a1ca3e81c04b26fbe07b634da6eb794412e36e.tar.gz |
insane: don't pass skip list to functions which don't respect it
When these functions are being called INSANE_SKIP has already been taken into
account, so don't confuse the code by passing the skip list.
(From OE-Core rev: 0001ceead406b1e8ba4fd16d0ecb5fbf5b55ba66)
Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
-rw-r--r-- | meta/classes/insane.bbclass | 16 |
1 files changed, 8 insertions, 8 deletions
diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass index 78b41caf99..ebcfacc492 100644 --- a/meta/classes/insane.bbclass +++ b/meta/classes/insane.bbclass | |||
@@ -732,7 +732,7 @@ def package_qa_check_staged(path,d): | |||
732 | return sane | 732 | return sane |
733 | 733 | ||
734 | # Run all package-wide warnfuncs and errorfuncs | 734 | # Run all package-wide warnfuncs and errorfuncs |
735 | def package_qa_package(warnfuncs, errorfuncs, skip, package, d): | 735 | def package_qa_package(warnfuncs, errorfuncs, package, d): |
736 | warnings = {} | 736 | warnings = {} |
737 | errors = {} | 737 | errors = {} |
738 | 738 | ||
@@ -749,7 +749,7 @@ def package_qa_package(warnfuncs, errorfuncs, skip, package, d): | |||
749 | return len(errors) == 0 | 749 | return len(errors) == 0 |
750 | 750 | ||
751 | # Run all recipe-wide warnfuncs and errorfuncs | 751 | # Run all recipe-wide warnfuncs and errorfuncs |
752 | def package_qa_recipe(warnfuncs, errorfuncs, skip, pn, d): | 752 | def package_qa_recipe(warnfuncs, errorfuncs, pn, d): |
753 | warnings = {} | 753 | warnings = {} |
754 | errors = {} | 754 | errors = {} |
755 | 755 | ||
@@ -766,7 +766,7 @@ def package_qa_recipe(warnfuncs, errorfuncs, skip, pn, d): | |||
766 | return len(errors) == 0 | 766 | return len(errors) == 0 |
767 | 767 | ||
768 | # Walk over all files in a directory and call func | 768 | # Walk over all files in a directory and call func |
769 | def package_qa_walk(warnfuncs, errorfuncs, skip, package, d): | 769 | def package_qa_walk(warnfuncs, errorfuncs, package, d): |
770 | import oe.qa | 770 | import oe.qa |
771 | 771 | ||
772 | #if this will throw an exception, then fix the dict above | 772 | #if this will throw an exception, then fix the dict above |
@@ -908,7 +908,7 @@ def package_qa_check_rdepends(pkg, pkgdest, skip, taskdeps, packages, d): | |||
908 | package_qa_handle_error("file-rdeps", error_msg, d) | 908 | package_qa_handle_error("file-rdeps", error_msg, d) |
909 | package_qa_check_rdepends[vardepsexclude] = "OVERRIDES" | 909 | package_qa_check_rdepends[vardepsexclude] = "OVERRIDES" |
910 | 910 | ||
911 | def package_qa_check_deps(pkg, pkgdest, skip, d): | 911 | def package_qa_check_deps(pkg, pkgdest, d): |
912 | 912 | ||
913 | localdata = bb.data.createCopy(d) | 913 | localdata = bb.data.createCopy(d) |
914 | localdata.setVar('OVERRIDES', pkg) | 914 | localdata.setVar('OVERRIDES', pkg) |
@@ -1108,16 +1108,16 @@ python do_package_qa () { | |||
1108 | "%s doesn't match the [a-z0-9.+-]+ regex" % package, d) | 1108 | "%s doesn't match the [a-z0-9.+-]+ regex" % package, d) |
1109 | 1109 | ||
1110 | warn_checks, error_checks = parse_test_matrix("QAPATHTEST") | 1110 | warn_checks, error_checks = parse_test_matrix("QAPATHTEST") |
1111 | package_qa_walk(warn_checks, error_checks, skip, package, d) | 1111 | package_qa_walk(warn_checks, error_checks, package, d) |
1112 | 1112 | ||
1113 | warn_checks, error_checks = parse_test_matrix("QAPKGTEST") | 1113 | warn_checks, error_checks = parse_test_matrix("QAPKGTEST") |
1114 | package_qa_package(warn_checks, error_checks, skip, package, d) | 1114 | package_qa_package(warn_checks, error_checks, package, d) |
1115 | 1115 | ||
1116 | package_qa_check_rdepends(package, pkgdest, skip, taskdeps, packages, d) | 1116 | package_qa_check_rdepends(package, pkgdest, skip, taskdeps, packages, d) |
1117 | package_qa_check_deps(package, pkgdest, skip, d) | 1117 | package_qa_check_deps(package, pkgdest, d) |
1118 | 1118 | ||
1119 | warn_checks, error_checks = parse_test_matrix("QARECIPETEST") | 1119 | warn_checks, error_checks = parse_test_matrix("QARECIPETEST") |
1120 | package_qa_recipe(warn_checks, error_checks, skip, pn, d) | 1120 | package_qa_recipe(warn_checks, error_checks, pn, d) |
1121 | 1121 | ||
1122 | if 'libdir' in d.getVar("ALL_QA").split(): | 1122 | if 'libdir' in d.getVar("ALL_QA").split(): |
1123 | package_qa_check_libdir(d) | 1123 | package_qa_check_libdir(d) |