diff options
author | Michael Opdenacker <michael.opdenacker@bootlin.com> | 2023-09-12 19:18:45 +0200 |
---|---|---|
committer | Richard Purdie <richard.purdie@linuxfoundation.org> | 2023-09-19 15:57:35 +0100 |
commit | 8b3a81f42f641ce93dbaa0232b701f281069ebdc (patch) | |
tree | 5aa8eb43c80245c4ad0d69744203658215b8ba49 | |
parent | 0c33a64edda790b35ff8288c288648214ab09f9f (diff) | |
download | poky-8b3a81f42f641ce93dbaa0232b701f281069ebdc.tar.gz |
contributor-guide: recipe-style-guide: add Upstream-Status
(From yocto-docs rev: 95c9a1e1e78bbfb82adef588f68d5d891fb64358)
Signed-off-by: Michael Opdenacker <michael.opdenacker@bootlin.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
-rw-r--r-- | documentation/contributor-guide/recipe-style-guide.rst | 81 |
1 files changed, 81 insertions, 0 deletions
diff --git a/documentation/contributor-guide/recipe-style-guide.rst b/documentation/contributor-guide/recipe-style-guide.rst index a0d513e8e9..99105179a6 100644 --- a/documentation/contributor-guide/recipe-style-guide.rst +++ b/documentation/contributor-guide/recipe-style-guide.rst | |||
@@ -255,3 +255,84 @@ Tips and Guidelines for Writing Recipes | |||
255 | - Use :term:`BBCLASSEXTEND` instead of creating separate recipes such as ``-native`` | 255 | - Use :term:`BBCLASSEXTEND` instead of creating separate recipes such as ``-native`` |
256 | and ``-nativesdk`` ones, whenever possible. This avoids having to maintain multiple | 256 | and ``-nativesdk`` ones, whenever possible. This avoids having to maintain multiple |
257 | recipe files at the same time. | 257 | recipe files at the same time. |
258 | |||
259 | Patch Upstream Status | ||
260 | ===================== | ||
261 | |||
262 | In order to keep track of patches applied by recipes and ultimately reduce the | ||
263 | number of patches that need maintaining, the OpenEmbedded build system | ||
264 | requires information about the upstream status of each patch. | ||
265 | |||
266 | In its description, each patch should provide detailed information about the | ||
267 | bug that it addresses, such as the URL in a bug tracking system and links | ||
268 | to relevant mailing list archives. | ||
269 | |||
270 | Then, you should also add an ``Upstream-Status:`` tag containing one of the | ||
271 | following status strings: | ||
272 | |||
273 | ``Pending`` | ||
274 | No determination has been made yet or not yet submitted to upstream. | ||
275 | |||
276 | ``Submitted [where]`` | ||
277 | Submitted to upstream, waiting for approval. Optionally include where | ||
278 | it was submitted, such as the author, mailing list, etc. | ||
279 | |||
280 | ``Accepted`` | ||
281 | Accepted in upstream, expect it to be removed at next update, include | ||
282 | expected version info. | ||
283 | |||
284 | ``Backport`` | ||
285 | Backported from new upstream version, because we are at a fixed version, | ||
286 | include upstream version info. | ||
287 | |||
288 | ``Denied`` | ||
289 | Not accepted by upstream, include reason in patch. | ||
290 | |||
291 | ``Inactive-Upstream [lastcommit: when (and/or) lastrelease: when]`` | ||
292 | The upstream is no longer available. This typically means a defunct project | ||
293 | where no activity has happened for a long time --- measured in years. To make | ||
294 | that judgement, it is recommended to look at not only when the last release | ||
295 | happened, but also when the last commit happened, and whether newly made bug | ||
296 | reports and merge requests since that time receive no reaction. It is also | ||
297 | recommended to add to the patch description any relevant links where the | ||
298 | inactivity can be clearly seen. | ||
299 | |||
300 | ``Inappropriate [reason]`` | ||
301 | The patch is not appropriate for upstream, include a brief reason on the | ||
302 | same line enclosed with ``[]``. The reason can be: | ||
303 | |||
304 | - ``not author`` (you are not the author and do not intend to upstream this, | ||
305 | the source must be listed in the comments) | ||
306 | - ``native`` | ||
307 | - ``licensing`` | ||
308 | - ``configuration`` | ||
309 | - ``enable feature`` | ||
310 | - ``disable feature`` | ||
311 | - ``bugfix`` (add bug URL here) | ||
312 | - ``embedded specific`` | ||
313 | - ``other`` (give details in comments) | ||
314 | |||
315 | The various ``Inappropriate [reason]`` status items are meant to indicate that | ||
316 | the person responsible for adding this patch to the system does not intend to | ||
317 | upstream the patch for a specific reason. | ||
318 | |||
319 | Of course, if another person later takes care of submitting this patch upstream, | ||
320 | the status should be changed to ``Submitted [where]``, and an additional | ||
321 | ``Signed-off-by:`` line should be added to the patch by the person claiming | ||
322 | responsibility for upstreaming. | ||
323 | |||
324 | For example, if the patch has been submitted upstream:: | ||
325 | |||
326 | rpm: Adjusted the foo setting in bar | ||
327 | |||
328 | [RPM Ticket #65] -- http://rpm5.org/cvs/tktview?tn=65,5 | ||
329 | |||
330 | The foo setting in bar was decreased from X to X-50% in order to | ||
331 | ensure we don't exhaust all system memory with foobar threads. | ||
332 | |||
333 | Upstream-Status: Submitted [rpm5-devel@rpm5.org] | ||
334 | |||
335 | Signed-off-by: Joe Developer <joe.developer@example.com> | ||
336 | |||
337 | A future update can change the value to ``Accepted`` or ``Denied`` as | ||
338 | appropriate. | ||