summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorWang Mingyu <wangmy@cn.fujitsu.com>2021-03-04 08:30:07 +0800
committerRichard Purdie <richard.purdie@linuxfoundation.org>2021-03-06 22:39:04 +0000
commit25197551fd00c091f4090d3e8386d721afeae75b (patch)
tree6f5f340f276d61b95b64a725a33d6ddd8b21a733
parent93b1881f5dfc5eb45f554e145601e0fb4306944a (diff)
downloadpoky-25197551fd00c091f4090d3e8386d721afeae75b.tar.gz
taglib: upgrade 1.11.1 -> 1.12
CVE-2017-12678.patch CVE-2018-11439.patch removed since they are included in 1.12 (From OE-Core rev: dc999d351ec599e4c534281585152087ff16d345) Signed-off-by: Wang Mingyu <wangmy@cn.fujitsu.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
-rw-r--r--meta/recipes-support/taglib/taglib/CVE-2017-12678.patch40
-rw-r--r--meta/recipes-support/taglib/taglib/CVE-2018-11439.patch51
-rw-r--r--meta/recipes-support/taglib/taglib_1.12.bb (renamed from meta/recipes-support/taglib/taglib_1.11.1.bb)9
3 files changed, 3 insertions, 97 deletions
diff --git a/meta/recipes-support/taglib/taglib/CVE-2017-12678.patch b/meta/recipes-support/taglib/taglib/CVE-2017-12678.patch
deleted file mode 100644
index 4bd9f2be17..0000000000
--- a/meta/recipes-support/taglib/taglib/CVE-2017-12678.patch
+++ /dev/null
@@ -1,40 +0,0 @@
1From eb9ded1206f18f2c319157337edea2533a40bea6 Mon Sep 17 00:00:00 2001
2From: "Stephen F. Booth" <me@sbooth.org>
3Date: Sun, 23 Jul 2017 10:11:09 -0400
4Subject: [PATCH] Don't assume TDRC is an instance of TextIdentificationFrame
5
6If TDRC is encrypted, FrameFactory::createFrame() returns UnknownFrame
7which causes problems in rebuildAggregateFrames() when it is assumed
8that TDRC is a TextIdentificationFrame
9
10Upstream-Status: Backport
11[https://github.com/taglib/taglib/pull/831/commits/eb9ded1206f18f2c319157337edea2533a40bea6]
12
13CVE: CVE-2017-12678
14
15Signed-off-by: Yi Zhao <yi.zhao@windriver.com>
16---
17 taglib/mpeg/id3v2/id3v2framefactory.cpp | 5 +++--
18 1 file changed, 3 insertions(+), 2 deletions(-)
19
20diff --git a/taglib/mpeg/id3v2/id3v2framefactory.cpp b/taglib/mpeg/id3v2/id3v2framefactory.cpp
21index 759a9b7b..9347ab86 100644
22--- a/taglib/mpeg/id3v2/id3v2framefactory.cpp
23+++ b/taglib/mpeg/id3v2/id3v2framefactory.cpp
24@@ -334,10 +334,11 @@ void FrameFactory::rebuildAggregateFrames(ID3v2::Tag *tag) const
25 tag->frameList("TDAT").size() == 1)
26 {
27 TextIdentificationFrame *tdrc =
28- static_cast<TextIdentificationFrame *>(tag->frameList("TDRC").front());
29+ dynamic_cast<TextIdentificationFrame *>(tag->frameList("TDRC").front());
30 UnknownFrame *tdat = static_cast<UnknownFrame *>(tag->frameList("TDAT").front());
31
32- if(tdrc->fieldList().size() == 1 &&
33+ if(tdrc &&
34+ tdrc->fieldList().size() == 1 &&
35 tdrc->fieldList().front().size() == 4 &&
36 tdat->data().size() >= 5)
37 {
38--
392.13.5
40
diff --git a/meta/recipes-support/taglib/taglib/CVE-2018-11439.patch b/meta/recipes-support/taglib/taglib/CVE-2018-11439.patch
deleted file mode 100644
index cdd66e67f7..0000000000
--- a/meta/recipes-support/taglib/taglib/CVE-2018-11439.patch
+++ /dev/null
@@ -1,51 +0,0 @@
1From 272648ccfcccae30e002ccf34a22e075dd477278 Mon Sep 17 00:00:00 2001
2From: Scott Gayou <github.scott@gmail.com>
3Date: Mon, 4 Jun 2018 11:34:36 -0400
4Subject: [PATCH] Fixed OOB read when loading invalid ogg flac file. (#868)
5
6This CVE is caused by a failure to check the minimum length
7of a ogg flac header. This header is detailed in full at:
8https://xiph.org/flac/ogg_mapping.html. Added more strict checking
9for entire header.
10
11Upstream-Status: Backport
12[https://github.com/taglib/taglib/pull/869/commits/272648ccfcccae30e002ccf34a22e075dd477278]
13
14CVE: CVE-2018-11439
15
16Signed-off-by: Yi Zhao <yi.zhao@windriver.com>
17---
18 taglib/ogg/flac/oggflacfile.cpp | 14 ++++++++++++--
19 1 file changed, 12 insertions(+), 2 deletions(-)
20
21diff --git a/taglib/ogg/flac/oggflacfile.cpp b/taglib/ogg/flac/oggflacfile.cpp
22index 53d0450..07ea9dc 100644
23--- a/taglib/ogg/flac/oggflacfile.cpp
24+++ b/taglib/ogg/flac/oggflacfile.cpp
25@@ -231,11 +231,21 @@ void Ogg::FLAC::File::scan()
26
27 if(!metadataHeader.startsWith("fLaC")) {
28 // FLAC 1.1.2+
29+ // See https://xiph.org/flac/ogg_mapping.html for the header specification.
30+ if(metadataHeader.size() < 13)
31+ return;
32+
33+ if(metadataHeader[0] != 0x7f)
34+ return;
35+
36 if(metadataHeader.mid(1, 4) != "FLAC")
37 return;
38
39- if(metadataHeader[5] != 1)
40- return; // not version 1
41+ if(metadataHeader[5] != 1 && metadataHeader[6] != 0)
42+ return; // not version 1.0
43+
44+ if(metadataHeader.mid(9, 4) != "fLaC")
45+ return;
46
47 metadataHeader = metadataHeader.mid(13);
48 }
49--
502.7.4
51
diff --git a/meta/recipes-support/taglib/taglib_1.11.1.bb b/meta/recipes-support/taglib/taglib_1.12.bb
index 165bccadc1..efa56253bb 100644
--- a/meta/recipes-support/taglib/taglib_1.11.1.bb
+++ b/meta/recipes-support/taglib/taglib_1.12.bb
@@ -9,13 +9,10 @@ LIC_FILES_CHKSUM = "file://COPYING.LGPL;md5=4fbd65380cdd255951079008b364516c \
9 9
10DEPENDS = "zlib" 10DEPENDS = "zlib"
11 11
12SRC_URI = "http://taglib.github.io/releases/${BP}.tar.gz \ 12SRC_URI = "http://taglib.github.io/releases/${BP}.tar.gz"
13 file://CVE-2017-12678.patch \
14 file://CVE-2018-11439.patch \
15 "
16 13
17SRC_URI[md5sum] = "cee7be0ccfc892fa433d6c837df9522a" 14SRC_URI[md5sum] = "4313ed2671234e029b7af8f97c84e9af"
18SRC_URI[sha256sum] = "b6d1a5a610aae6ff39d93de5efd0fdc787aa9e9dc1e7026fa4c961b26563526b" 15SRC_URI[sha256sum] = "7fccd07669a523b07a15bd24c8da1bbb92206cb19e9366c3692af3d79253b703"
19 16
20UPSTREAM_CHECK_URI = "http://github.com/taglib/taglib/releases/" 17UPSTREAM_CHECK_URI = "http://github.com/taglib/taglib/releases/"
21 18