summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRichard Purdie <richard.purdie@linuxfoundation.org>2011-12-17 10:08:53 +0000
committerRichard Purdie <richard.purdie@linuxfoundation.org>2012-01-05 12:36:28 +0000
commit0fa52f70789afe5a53384ba20249af34c16a8568 (patch)
tree10922171df8f0e469961b727a9f1ebb2830cd719
parent5aabdbaff7b8be319a86c5e33cc2eb8c2e4aa2ef (diff)
downloadpoky-0fa52f70789afe5a53384ba20249af34c16a8568.tar.gz
native.bbclass: Fix variable remapping coverage
When looking for RDEPENDS to process, bitbake iterates through PACKAGES *and* PN. Since native.bbclass sets PACKAGES to be empty, its pointless remapping the list of PACKAGES since this does nothing. There is a problem since *_${PN} are used by bitbake but not remapped by the native.bbclass class extension code. This changes the code to remap _${PN} in both expanded and unexpanded forms. As a result of this, various surprising dependencies are uncovered and the patch rectifies those. These are real bugs since they're injecting unneeded (unremapped) dependencies into the dependency chain. (From OE-Core rev: 0f485bfd6fc82a109b9da629e464fca1e90faec3) Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
-rw-r--r--meta/classes/native.bbclass2
-rw-r--r--meta/recipes-devtools/autoconf/autoconf.inc2
-rw-r--r--meta/recipes-devtools/autoconf/autoconf_2.68.bb8
-rw-r--r--meta/recipes-devtools/automake/automake_1.11.2.bb5
-rw-r--r--meta/recipes-devtools/python/python-native_2.7.2.bb2
-rw-r--r--meta/recipes-gnome/gnome/gconf_3.2.3.bb1
-rw-r--r--meta/recipes-support/boost/boost.inc1
7 files changed, 10 insertions, 11 deletions
diff --git a/meta/classes/native.bbclass b/meta/classes/native.bbclass
index 49823d6fc6..00196baba8 100644
--- a/meta/classes/native.bbclass
+++ b/meta/classes/native.bbclass
@@ -127,7 +127,7 @@ python native_virtclass_handler () {
127 d.setVar(varname, " ".join(newdeps)) 127 d.setVar(varname, " ".join(newdeps))
128 128
129 map_dependencies("DEPENDS", e.data) 129 map_dependencies("DEPENDS", e.data)
130 for pkg in (e.data.getVar("PACKAGES", True).split() + [""]): 130 for pkg in [e.data.getVar("PN", True), "", "${PN}"]:
131 map_dependencies("RDEPENDS", e.data, pkg) 131 map_dependencies("RDEPENDS", e.data, pkg)
132 map_dependencies("RRECOMMENDS", e.data, pkg) 132 map_dependencies("RRECOMMENDS", e.data, pkg)
133 map_dependencies("RSUGGESTS", e.data, pkg) 133 map_dependencies("RSUGGESTS", e.data, pkg)
diff --git a/meta/recipes-devtools/autoconf/autoconf.inc b/meta/recipes-devtools/autoconf/autoconf.inc
index 08a1b02219..1d0cf900fc 100644
--- a/meta/recipes-devtools/autoconf/autoconf.inc
+++ b/meta/recipes-devtools/autoconf/autoconf.inc
@@ -6,6 +6,8 @@ LICENSE = "GPLv3"
6HOMEPAGE = "http://www.gnu.org/software/autoconf/" 6HOMEPAGE = "http://www.gnu.org/software/autoconf/"
7SECTION = "devel" 7SECTION = "devel"
8DEPENDS += "m4-native" 8DEPENDS += "m4-native"
9DEPENDS_virtclass-native = "m4-native gnu-config-native"
10DEPENDS_virtclass-nativesdk = "m4-nativesdk gnu-config-nativesdk"
9RDEPENDS_${PN} = "m4 gnu-config" 11RDEPENDS_${PN} = "m4 gnu-config"
10 12
11SRC_URI = "${GNU_MIRROR}/autoconf/autoconf-${PV}.tar.bz2 \ 13SRC_URI = "${GNU_MIRROR}/autoconf/autoconf-${PV}.tar.bz2 \
diff --git a/meta/recipes-devtools/autoconf/autoconf_2.68.bb b/meta/recipes-devtools/autoconf/autoconf_2.68.bb
index 9028e8336b..84eb1821b4 100644
--- a/meta/recipes-devtools/autoconf/autoconf_2.68.bb
+++ b/meta/recipes-devtools/autoconf/autoconf_2.68.bb
@@ -4,8 +4,6 @@ PR = "r4"
4 4
5PARALLEL_MAKE = "" 5PARALLEL_MAKE = ""
6 6
7DEPENDS += "m4-native"
8RDEPENDS_${PN} = "m4 gnu-config"
9LICENSE = "GPLv2 & GPLv3" 7LICENSE = "GPLv2 & GPLv3"
10LIC_FILES_CHKSUM = "file://COPYING;md5=751419260aa954499f7abaabaa882bbe \ 8LIC_FILES_CHKSUM = "file://COPYING;md5=751419260aa954499f7abaabaa882bbe \
11 file://COPYINGv3;md5=d32239bcb673463ab874e80d47fae504" 9 file://COPYINGv3;md5=d32239bcb673463ab874e80d47fae504"
@@ -22,12 +20,6 @@ SRC_URI += "file://autoreconf-include.patch \
22SRC_URI[md5sum] = "864d785215aa60d627c91fcb21b05b07" 20SRC_URI[md5sum] = "864d785215aa60d627c91fcb21b05b07"
23SRC_URI[sha256sum] = "c491fb273fd6d4ca925e26ceed3d177920233c76d542b150ff35e571454332c8" 21SRC_URI[sha256sum] = "c491fb273fd6d4ca925e26ceed3d177920233c76d542b150ff35e571454332c8"
24 22
25DEPENDS_virtclass-native = "m4-native gnu-config-native"
26RDEPENDS_${PN}_virtclass-native = "m4-native gnu-config-native"
27
28DEPENDS_virtclass-nativesdk = "m4-nativesdk gnu-config-nativesdk"
29RDEPENDS_${PN}_virtclass-nativesdk = "m4-nativesdk gnu-config-nativesdk"
30
31SRC_URI_append_virtclass-native = " file://fix_path_xtra.patch" 23SRC_URI_append_virtclass-native = " file://fix_path_xtra.patch"
32 24
33EXTRA_OECONF += "ac_cv_path_M4=m4" 25EXTRA_OECONF += "ac_cv_path_M4=m4"
diff --git a/meta/recipes-devtools/automake/automake_1.11.2.bb b/meta/recipes-devtools/automake/automake_1.11.2.bb
index b455edfe6f..0a65f24fbe 100644
--- a/meta/recipes-devtools/automake/automake_1.11.2.bb
+++ b/meta/recipes-devtools/automake/automake_1.11.2.bb
@@ -3,7 +3,7 @@ LICENSE="GPLv2"
3LIC_FILES_CHKSUM = "file://COPYING;md5=751419260aa954499f7abaabaa882bbe" 3LIC_FILES_CHKSUM = "file://COPYING;md5=751419260aa954499f7abaabaa882bbe"
4DEPENDS_virtclass-native = "autoconf-native" 4DEPENDS_virtclass-native = "autoconf-native"
5 5
6RDEPENDS_automake += "\ 6RDEPENDS_${PN} += "\
7 autoconf \ 7 autoconf \
8 perl \ 8 perl \
9 perl-module-bytes \ 9 perl-module-bytes \
@@ -27,7 +27,8 @@ RDEPENDS_automake += "\
27 perl-module-text-parsewords \ 27 perl-module-text-parsewords \
28 perl-module-vars " 28 perl-module-vars "
29 29
30RDEPENDS_automake-native = "autoconf-native perl-native-runtime" 30RDEPENDS_${PN}_virtclass-native = "autoconf-native perl-native-runtime"
31RDEPENDS_${PN}_virtclass-nativesdk = "autoconf-nativesdk"
31 32
32PATHFIXPATCH = "file://path_prog_fixes.patch" 33PATHFIXPATCH = "file://path_prog_fixes.patch"
33PATHFIXPATCH_virtclass-native = "" 34PATHFIXPATCH_virtclass-native = ""
diff --git a/meta/recipes-devtools/python/python-native_2.7.2.bb b/meta/recipes-devtools/python/python-native_2.7.2.bb
index 8bf736d1ec..67b546d76e 100644
--- a/meta/recipes-devtools/python/python-native_2.7.2.bb
+++ b/meta/recipes-devtools/python/python-native_2.7.2.bb
@@ -18,6 +18,8 @@ S = "${WORKDIR}/Python-${PV}"
18 18
19inherit native 19inherit native
20 20
21RPROVIDES += "python-distutils-native python-compression-native python-textutils-native"
22
21EXTRA_OEMAKE = '\ 23EXTRA_OEMAKE = '\
22 BUILD_SYS="" \ 24 BUILD_SYS="" \
23 HOST_SYS="" \ 25 HOST_SYS="" \
diff --git a/meta/recipes-gnome/gnome/gconf_3.2.3.bb b/meta/recipes-gnome/gnome/gconf_3.2.3.bb
index 9d327fce85..f7d35946d3 100644
--- a/meta/recipes-gnome/gnome/gconf_3.2.3.bb
+++ b/meta/recipes-gnome/gnome/gconf_3.2.3.bb
@@ -39,6 +39,7 @@ do_install_append() {
39 39
40# disable dbus-x11 when x11 isn't in DISTRO_FEATURES 40# disable dbus-x11 when x11 isn't in DISTRO_FEATURES
41RDEPENDS_${PN} += "${@base_contains('DISTRO_FEATURES', 'x11', 'dbus-x11', '', d)}" 41RDEPENDS_${PN} += "${@base_contains('DISTRO_FEATURES', 'x11', 'dbus-x11', '', d)}"
42RDEPENDS_${PN}_virtclass-native = ""
42 43
43FILES_${PN} += "${libdir}/GConf/* \ 44FILES_${PN} += "${libdir}/GConf/* \
44 ${libdir}/gio/*/*.so \ 45 ${libdir}/gio/*/*.so \
diff --git a/meta/recipes-support/boost/boost.inc b/meta/recipes-support/boost/boost.inc
index dfe00f2753..74f3e4ba3f 100644
--- a/meta/recipes-support/boost/boost.inc
+++ b/meta/recipes-support/boost/boost.inc
@@ -74,6 +74,7 @@ FILES_${PN}-dev = "${includedir} ${libdir}/libboost_*.so ${libdir}/libboost_*.a"
74# "boost" is a metapackage which pulls in all boost librabries 74# "boost" is a metapackage which pulls in all boost librabries
75PACKAGES += "${PN}" 75PACKAGES += "${PN}"
76RRECOMMENDS_${PN} += "${BOOST_PACKAGES}" 76RRECOMMENDS_${PN} += "${BOOST_PACKAGES}"
77RRECOMMENDS_${PN}_virtclass-native = ""
77ALLOW_EMPTY_${PN} = "1" 78ALLOW_EMPTY_${PN} = "1"
78 79
79# to avoid GNU_HASH QA errors added LDFLAGS to ARCH; a little bit dirty but at least it works 80# to avoid GNU_HASH QA errors added LDFLAGS to ARCH; a little bit dirty but at least it works