summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAndre McCurdy <armccurdy@gmail.com>2016-01-19 18:47:49 -0800
committerRichard Purdie <richard.purdie@linuxfoundation.org>2016-01-24 09:40:21 +0000
commitb0b34127cb6d47eed4b4f5f31392f3a3bf23a6ae (patch)
tree5eccc95f28f335f42a46d23f85a313da8aa5f1f5
parent92abb5f1ceb24983c9e432013ee5c63daa461048 (diff)
downloadpoky-b0b34127cb6d47eed4b4f5f31392f3a3bf23a6ae.tar.gz
valgrind: let valgrind determine its own optimisation flags
Valgrind likes to control its own optimisation flags. It generally defaults to -O2 but uses -O0 for some specific test apps etc. Passing our own flags (via CFLAGS) means we interfere with that. Giving valgrind control of optimisation is hopefully an even better solution than the previous one of forcing -O0 for all tests. http://git.openembedded.org/openembedded-core/commit/?h=master-next&id=98c4a3ffb8dca10739be600e8d6df7fb6aa4958f (From OE-Core rev: 1c8ed8dada8d3399bd825d6f34fc440ce793ec4e) Signed-off-by: Andre McCurdy <armccurdy@gmail.com> Signed-off-by: Ross Burton <ross.burton@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
-rw-r--r--meta/recipes-devtools/valgrind/valgrind_3.11.0.bb9
1 files changed, 6 insertions, 3 deletions
diff --git a/meta/recipes-devtools/valgrind/valgrind_3.11.0.bb b/meta/recipes-devtools/valgrind/valgrind_3.11.0.bb
index 70d84fe9a2..8e9b72cd61 100644
--- a/meta/recipes-devtools/valgrind/valgrind_3.11.0.bb
+++ b/meta/recipes-devtools/valgrind/valgrind_3.11.0.bb
@@ -44,6 +44,11 @@ EXTRA_OECONF_append_arm = " --host=armv7${HOST_VENDOR}-${HOST_OS}"
44 44
45EXTRA_OEMAKE = "-w" 45EXTRA_OEMAKE = "-w"
46 46
47# valgrind likes to control its own optimisation flags. It generally defaults
48# to -O2 but uses -O0 for some specific test apps etc. Passing our own flags
49# (via CFLAGS) means we interfere with that.
50SELECTED_OPTIMIZATION = ""
51
47CFLAGS_append_libc-uclibc = " -D__UCLIBC__ " 52CFLAGS_append_libc-uclibc = " -D__UCLIBC__ "
48 53
49do_install_append () { 54do_install_append () {
@@ -63,10 +68,9 @@ RDEPENDS_${PN}-ptest += " sed perl glibc-utils perl-module-file-glob"
63INSANE_SKIP_${PN}-ptest += "file-rdeps" 68INSANE_SKIP_${PN}-ptest += "file-rdeps"
64 69
65do_compile_ptest() { 70do_compile_ptest() {
66 oe_runmake check CFLAGS="${CFLAGS} -O0" CXXFLAGS="${CXXFLAGS} -O0" 71 oe_runmake check
67} 72}
68 73
69
70do_install_ptest() { 74do_install_ptest() {
71 chmod +x ${B}/tests/vg_regtest 75 chmod +x ${B}/tests/vg_regtest
72 76
@@ -107,4 +111,3 @@ do_install_ptest() {
107 # handle multilib 111 # handle multilib
108 sed -i s:@libdir@:${libdir}:g ${D}${PTEST_PATH}/run-ptest 112 sed -i s:@libdir@:${libdir}:g ${D}${PTEST_PATH}/run-ptest
109} 113}
110