diff options
author | Chen Qi <Qi.Chen@windriver.com> | 2019-04-12 09:40:06 +0800 |
---|---|---|
committer | Richard Purdie <richard.purdie@linuxfoundation.org> | 2019-05-22 00:31:48 +0100 |
commit | a84ff1c0625f03a0fde7da2e56bd16b5422bd974 (patch) | |
tree | d058afa8c5572f203daa836a098c47c6867d9984 | |
parent | dfc74324c94e5c90f0f802b21cfc84fadebcff33 (diff) | |
download | poky-a84ff1c0625f03a0fde7da2e56bd16b5422bd974.tar.gz |
runqemu: do not check return code of tput
The subprocess.run was replaced by subprocess.check_call because
of compatibility support down to python 3.4. But we really don't
care about whether that command succeeds. Some user reports that
in some tmux environment, this command fails and gives some
unpleasant traceback output. So we use 'call' instead of 'check_call'
to avoid such problem.
(From OE-Core rev: ced3c75fa75d9b9373d695d9204b197b98ea3bd9)
Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Signed-off-by: Armin Kuster <akuster808@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
-rwxr-xr-x | scripts/runqemu | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/scripts/runqemu b/scripts/runqemu index 1c96b29a40..f83e05728b 100755 --- a/scripts/runqemu +++ b/scripts/runqemu | |||
@@ -1333,7 +1333,8 @@ def main(): | |||
1333 | logger.info("SIGTERM received") | 1333 | logger.info("SIGTERM received") |
1334 | os.kill(config.qemupid, signal.SIGTERM) | 1334 | os.kill(config.qemupid, signal.SIGTERM) |
1335 | config.cleanup() | 1335 | config.cleanup() |
1336 | subprocess.check_call(["tput", "smam"]) | 1336 | # Deliberately ignore the return code of 'tput smam'. |
1337 | subprocess.call(["tput", "smam"]) | ||
1337 | signal.signal(signal.SIGTERM, sigterm_handler) | 1338 | signal.signal(signal.SIGTERM, sigterm_handler) |
1338 | 1339 | ||
1339 | config.check_args() | 1340 | config.check_args() |
@@ -1355,7 +1356,8 @@ def main(): | |||
1355 | return 1 | 1356 | return 1 |
1356 | finally: | 1357 | finally: |
1357 | config.cleanup() | 1358 | config.cleanup() |
1358 | subprocess.check_call(["tput", "smam"]) | 1359 | # Deliberately ignore the return code of 'tput smam'. |
1360 | subprocess.call(["tput", "smam"]) | ||
1359 | 1361 | ||
1360 | if __name__ == "__main__": | 1362 | if __name__ == "__main__": |
1361 | sys.exit(main()) | 1363 | sys.exit(main()) |