diff options
| author | Martin Jansa <martin.jansa@gmail.com> | 2019-09-04 07:37:00 +0000 |
|---|---|---|
| committer | Richard Purdie <richard.purdie@linuxfoundation.org> | 2019-09-06 11:58:56 +0100 |
| commit | dab13e1c79684126f271833b85a8bc9d1f830315 (patch) | |
| tree | 8c488d85892aada44c6e13ba90f79e7d82a3644c | |
| parent | 3103c383b3aa637a8f81582ddd5bc67aff46b3f5 (diff) | |
| download | poky-dab13e1c79684126f271833b85a8bc9d1f830315.tar.gz | |
bitbake: fetch2: show warning when renaming the archive with bad checksum failed
* noticed on read-only sshfs premirror
* it was showing the warning about renaming the file:
WARNING: laser-geometry-1.6.4-r0 do_fetch: Renaming /jenkins/mjansa/sshfs/webos-ose-thud/downloads/laser_geometry-1.6.4.tar.gz to /jenkins/mjansa/sshfs/webos-ose-thud/downloads/laser_geometry-1.6.4.tar.gz_bad-checksum_1ee7479b8c5914b4ffae996945121441
and then failed because of movefile() issue with python3 (fixed in previous commit):
ERROR: laser-geometry-1.6.4-r0 do_fetch: Error executing a python function in exec_python_func() autogenerated:
with movefile() fixed, it let do_fetch continue and re-fetch locally with the right
checksum, but still the renamed file didn't exist, because of movefile failure - add
another warning when the movefile fails - for whatever reason - unfortunately movefile
prints error messages with just print() so the real error is hidden only in log.do_fetch
in this case:
movefile: Failed to move /jenkins/mjansa/sshfs/webos-ose-thud/downloads/laser_geometry-1.6.4.tar.gz to /jenkins/mjansa/sshfs/webos-ose-thud/downloads/laser_geometry-1.6.4.tar.gz_bad-checksum_1ee7479b8c5914b4ffae996945121441 [Errno 30] Read-only file system: '/jenkins/mjansa/sshfs/webos-ose-thud/downloads/laser_geometry-1.6.4.tar.gz' -> '/jenkins/mjansa/sshfs/webos-ose-thud/downloads/laser_geometry-1.6.4.tar.gz_bad-checksum_1ee7479b8c5914b4ffae996945121441'
(Bitbake rev: d36438759344caa447d9a0bf30749a0aa31d1fba)
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
| -rw-r--r-- | bitbake/lib/bb/fetch2/__init__.py | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/bitbake/lib/bb/fetch2/__init__.py b/bitbake/lib/bb/fetch2/__init__.py index 709372e16f..708b83dbfa 100644 --- a/bitbake/lib/bb/fetch2/__init__.py +++ b/bitbake/lib/bb/fetch2/__init__.py | |||
| @@ -966,7 +966,8 @@ def rename_bad_checksum(ud, suffix): | |||
| 966 | 966 | ||
| 967 | new_localpath = "%s_bad-checksum_%s" % (ud.localpath, suffix) | 967 | new_localpath = "%s_bad-checksum_%s" % (ud.localpath, suffix) |
| 968 | bb.warn("Renaming %s to %s" % (ud.localpath, new_localpath)) | 968 | bb.warn("Renaming %s to %s" % (ud.localpath, new_localpath)) |
| 969 | bb.utils.movefile(ud.localpath, new_localpath) | 969 | if not bb.utils.movefile(ud.localpath, new_localpath): |
| 970 | bb.warn("Renaming %s to %s failed, grep movefile in log.do_fetch to see why" % (ud.localpath, new_localpath)) | ||
| 970 | 971 | ||
| 971 | 972 | ||
| 972 | def try_mirror_url(fetch, origud, ud, ld, check = False): | 973 | def try_mirror_url(fetch, origud, ud, ld, check = False): |