diff options
author | Patrick Williams <patrick@stwcx.xyz> | 2023-04-28 11:07:57 -0500 |
---|---|---|
committer | Richard Purdie <richard.purdie@linuxfoundation.org> | 2023-05-04 12:34:30 +0100 |
commit | b7574378e8d310413805f87d7dccc9063f433b5a (patch) | |
tree | 48d688131db9d1adb15800293f5a191471041471 | |
parent | fb8d21e73fbe3692bc1aa3455f957eb26c6b5ea8 (diff) | |
download | poky-b7574378e8d310413805f87d7dccc9063f433b5a.tar.gz |
perl-version: remove PERL* assignments
The perl-version.bbclass executes functions which can depend on
variables potentially populated by native, such as `libdir`. The
sanity `native-last` suggests that recipes should `inherit native`
last, but when that is done the variables like PERLVERSION end up
as `None`, since `${STAGING_LIBDIR}` needs `${libdir}` which is not
yet populated (by native).
All recipes in poky and widely used meta-layers have already been
updated to use the functions directly instead of relying on these
problematic variables. Delete the variables so that future recipes
do not make the mistake of using them.
Related: openbmc/openbmc#3770
(From OE-Core rev: 9351b6e7fab5669340bb062b9c84fb4faa3dce0b)
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
-rw-r--r-- | meta/classes-recipe/perl-version.bbclass | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/meta/classes-recipe/perl-version.bbclass b/meta/classes-recipe/perl-version.bbclass index 269ac9eb31..74e33175d9 100644 --- a/meta/classes-recipe/perl-version.bbclass +++ b/meta/classes-recipe/perl-version.bbclass | |||
@@ -26,9 +26,6 @@ def get_perl_version(d): | |||
26 | return m.group(1) | 26 | return m.group(1) |
27 | return None | 27 | return None |
28 | 28 | ||
29 | PERLVERSION := "${@get_perl_version(d)}" | ||
30 | PERLVERSION[vardepvalue] = "" | ||
31 | |||
32 | 29 | ||
33 | # Determine the staged arch of perl from the perl configuration file | 30 | # Determine the staged arch of perl from the perl configuration file |
34 | # Assign vardepvalue, because otherwise signature is changed before and after | 31 | # Assign vardepvalue, because otherwise signature is changed before and after |
@@ -49,9 +46,6 @@ def get_perl_arch(d): | |||
49 | return m.group(1) | 46 | return m.group(1) |
50 | return None | 47 | return None |
51 | 48 | ||
52 | PERLARCH := "${@get_perl_arch(d)}" | ||
53 | PERLARCH[vardepvalue] = "" | ||
54 | |||
55 | # Determine the staged arch of perl-native from the perl configuration file | 49 | # Determine the staged arch of perl-native from the perl configuration file |
56 | # Assign vardepvalue, because otherwise signature is changed before and after | 50 | # Assign vardepvalue, because otherwise signature is changed before and after |
57 | # perl is built (from None to real version in config.sh). | 51 | # perl is built (from None to real version in config.sh). |