diff options
author | Gavin Li <gavin@matician.com> | 2019-11-11 14:17:39 -0800 |
---|---|---|
committer | Richard Purdie <richard.purdie@linuxfoundation.org> | 2019-11-14 14:06:42 +0000 |
commit | f320d4808ad4080ed9b54e0cf422411331241c5f (patch) | |
tree | a330ce70950960ba657fe5c6ca4a8bc0727e0132 | |
parent | a60b54046f079ae0f22e5bf6ae4f4083155ef818 (diff) | |
download | poky-f320d4808ad4080ed9b54e0cf422411331241c5f.tar.gz |
bitbake: prserv: fix ResourceWarning due to unclosed socket
With PRSERV_HOST = "localhost:0", this message would occasionally pop up
during the initial cache read:
WARNING: /home/matic/ambayocto/poky/bitbake/lib/bb/cache.py:446: ResourceWarning: unclosed <socket.socket fd=10, family=AddressFamily.AF_INET, type=SocketKind.SOCK_STREAM, proto=0, laddr=('127.0.0.1', 45655)>
value = pickled.load()
The file location stated is irrelevant; it just happens to be wherever
CPython decides to run the garbage collector. The issue is that after we
fork off a PRServer, self.socket is also duplicated. The parent side of
it also needs to be closed.
(Bitbake rev: c45b0140c37f2d68c4fa08cd17f0321b8d6524a8)
Signed-off-by: Gavin Li <gavin@matician.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
-rw-r--r-- | bitbake/lib/prserv/serv.py | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/bitbake/lib/prserv/serv.py b/bitbake/lib/prserv/serv.py index 2bc68904f3..b854ba14b7 100644 --- a/bitbake/lib/prserv/serv.py +++ b/bitbake/lib/prserv/serv.py | |||
@@ -243,6 +243,7 @@ class PRServer(SimpleXMLRPCServer): | |||
243 | try: | 243 | try: |
244 | pid = os.fork() | 244 | pid = os.fork() |
245 | if pid > 0: | 245 | if pid > 0: |
246 | self.socket.close() # avoid ResourceWarning in parent | ||
246 | return pid | 247 | return pid |
247 | except OSError as e: | 248 | except OSError as e: |
248 | raise Exception("%s [%d]" % (e.strerror, e.errno)) | 249 | raise Exception("%s [%d]" % (e.strerror, e.errno)) |