diff options
author | Michael Opdenacker <michael.opdenacker@bootlin.com> | 2024-04-12 11:02:32 +0200 |
---|---|---|
committer | Richard Purdie <richard.purdie@linuxfoundation.org> | 2024-04-14 06:31:45 +0100 |
commit | 9889a0ff1af115e37ea1268f0580ef8b344c32e9 (patch) | |
tree | 4f2bf2bd15a32930bb9288717ba119a7241d9bf6 | |
parent | f2a83b50b34d371f6eea2fb734dbeceb108e4f51 (diff) | |
download | poky-9889a0ff1af115e37ea1268f0580ef8b344c32e9.tar.gz |
bitbake: prserv: remove unnecessary code
In db.py, the ifnull() statement guarantees that the SQL request will
return a value. It's therefore unnecessary to test the case when no
value is found.
(Bitbake rev: e4ae5177861c9a27e93e5a2d3a6c393baecd6416)
Signed-off-by: Michael Opdenacker <michael.opdenacker@bootlin.com>
Cc: Joshua Watt <JPEWhacker@gmail.com>
Cc: Tim Orling <ticotimo@gmail.com>
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
-rw-r--r-- | bitbake/lib/prserv/db.py | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/bitbake/lib/prserv/db.py b/bitbake/lib/prserv/db.py index 7c200602ed..eb41508198 100644 --- a/bitbake/lib/prserv/db.py +++ b/bitbake/lib/prserv/db.py | |||
@@ -172,11 +172,7 @@ class PRTable(object): | |||
172 | if self.read_only: | 172 | if self.read_only: |
173 | data = self._execute("SELECT ifnull(max(value)+1, 0) FROM %s where version=? AND pkgarch=?;" % (self.table), | 173 | data = self._execute("SELECT ifnull(max(value)+1, 0) FROM %s where version=? AND pkgarch=?;" % (self.table), |
174 | (version, pkgarch)) | 174 | (version, pkgarch)) |
175 | row = data.fetchone() | 175 | return data.fetchone()[0] |
176 | if row is not None: | ||
177 | return row[0] | ||
178 | else: | ||
179 | return 0 | ||
180 | 176 | ||
181 | try: | 177 | try: |
182 | self._execute("INSERT OR REPLACE INTO %s VALUES (?, ?, ?, (select ifnull(max(value)+1, 0) from %s where version=? AND pkgarch=?));" | 178 | self._execute("INSERT OR REPLACE INTO %s VALUES (?, ?, ?, (select ifnull(max(value)+1, 0) from %s where version=? AND pkgarch=?));" |