summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorTrevor Gamblin <trevor.gamblin@windriver.com>2019-10-03 18:45:43 -0400
committerRichard Purdie <richard.purdie@linuxfoundation.org>2019-10-08 11:22:24 +0100
commit621a5836dd712a75f00996e45381aef03ad76c20 (patch)
tree4b662a695891afe900bc29bea49132e388cf8cbc
parent0221e2e6e1948a5b22255df8aefcb665e7114e26 (diff)
downloadpoky-621a5836dd712a75f00996e45381aef03ad76c20.tar.gz
lib/oe/terminal.py: fix gnome-terminal start behavior
[Bugzilla Bug 13201] -- https://bugzilla.yoctoproject.org/show_bug.cgi?id=13201 Newer versions of gnome-terminal (3.32.0 and up) are not starting as expected for commands e.g. "bitbake -c devshell zlib". This manifests as the instance appearing as a new tab rather than a new window. Fix this (and maintain new window preferred behavior) by changing the "-x" option to "--" as per the warning message, avoiding deprecated options: # Option “--command” is deprecated and might be removed in a later version of gnome-terminal. # Use “-- ” to terminate the options and put the command line to execute after it. (From OE-Core rev: d5fd205239c8e3a1d68649562a7e91c8fbbc805e) Signed-off-by: Trevor Gamblin <trevor.gamblin@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
-rw-r--r--meta/lib/oe/terminal.py2
1 files changed, 1 insertions, 1 deletions
diff --git a/meta/lib/oe/terminal.py b/meta/lib/oe/terminal.py
index 9bda3efdc7..a1daa2bed6 100644
--- a/meta/lib/oe/terminal.py
+++ b/meta/lib/oe/terminal.py
@@ -55,7 +55,7 @@ class XTerminal(Terminal):
55 raise UnsupportedTerminal(self.name) 55 raise UnsupportedTerminal(self.name)
56 56
57class Gnome(XTerminal): 57class Gnome(XTerminal):
58 command = 'gnome-terminal -t "{title}" -x {command}' 58 command = 'gnome-terminal -t "{title}" -- {command}'
59 priority = 2 59 priority = 2
60 60
61 def __init__(self, sh_cmd, title=None, env=None, d=None): 61 def __init__(self, sh_cmd, title=None, env=None, d=None):