diff options
author | Paul Eggleton <paul.eggleton@linux.intel.com> | 2016-02-22 11:56:08 +1300 |
---|---|---|
committer | Richard Purdie <richard.purdie@linuxfoundation.org> | 2016-02-28 11:33:00 +0000 |
commit | e953b5711fe5eae53cbb5b4fab1260bf07631f86 (patch) | |
tree | e5544b53e5067d0340ef923d58a90e4b3ec2eebe | |
parent | 492b1eb1d2457bea2fd8fdd8fb5ef4e69a3af790 (diff) | |
download | poky-e953b5711fe5eae53cbb5b4fab1260bf07631f86.tar.gz |
devtool: upgrade: drop superfluous call to validate_pn
The recipename argument to devtool upgrade specifies an existing recipe,
so by definition the name will be valid (or it won't exist) - we don't
need to validate it ourselves, that's only needed for situations like in
devtool add where we're creating a new recipe.
(From OE-Core rev: 1e2bc7d861555a04350a87f19047efdc717046be)
Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
-rw-r--r-- | scripts/lib/devtool/upgrade.py | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/scripts/lib/devtool/upgrade.py b/scripts/lib/devtool/upgrade.py index a446c557bc..279a65f62a 100644 --- a/scripts/lib/devtool/upgrade.py +++ b/scripts/lib/devtool/upgrade.py | |||
@@ -297,12 +297,7 @@ def upgrade(args, config, basepath, workspace): | |||
297 | if args.srcbranch and not args.srcrev: | 297 | if args.srcbranch and not args.srcrev: |
298 | raise DevtoolError("If you specify --srcbranch/-B then you must use --srcrev/-S to specify the revision" % args.recipename) | 298 | raise DevtoolError("If you specify --srcbranch/-B then you must use --srcrev/-S to specify the revision" % args.recipename) |
299 | 299 | ||
300 | reason = oe.recipeutils.validate_pn(args.recipename) | ||
301 | if reason: | ||
302 | raise DevtoolError(reason) | ||
303 | |||
304 | tinfoil = setup_tinfoil(basepath=basepath, tracking=True) | 300 | tinfoil = setup_tinfoil(basepath=basepath, tracking=True) |
305 | |||
306 | rd = parse_recipe(config, tinfoil, args.recipename, True) | 301 | rd = parse_recipe(config, tinfoil, args.recipename, True) |
307 | if not rd: | 302 | if not rd: |
308 | return 1 | 303 | return 1 |