summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorWang Mingyu <wangmy@fujitsu.com>2024-04-24 16:42:12 +0800
committerRichard Purdie <richard.purdie@linuxfoundation.org>2024-04-24 14:27:54 +0100
commit5f89f2ffc4c3b24e92a3e76f3d3fe7868f6f1a47 (patch)
tree77789574ee8b81d47053623a2d5f08ad43af3049
parent8403c794d0f225e8943db91b110e448a4ec61f46 (diff)
downloadpoky-5f89f2ffc4c3b24e92a3e76f3d3fe7868f6f1a47.tar.gz
openssl: upgrade 3.2.1 -> 3.3.0
CVE-2024-2511.patch revmoed since it's included in 3.3.0 Changelog: https://github.com/openssl/openssl/blob/openssl-3.3.0/NEWS.md (From OE-Core rev: 9d1cb9380b8ba286b5708d444aa47f206e40b843) Signed-off-by: Wang Mingyu <wangmy@fujitsu.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
-rw-r--r--meta/recipes-connectivity/openssl/openssl/CVE-2024-2511.patch120
-rw-r--r--meta/recipes-connectivity/openssl/openssl_3.3.0.bb (renamed from meta/recipes-connectivity/openssl/openssl_3.2.1.bb)3
2 files changed, 1 insertions, 122 deletions
diff --git a/meta/recipes-connectivity/openssl/openssl/CVE-2024-2511.patch b/meta/recipes-connectivity/openssl/openssl/CVE-2024-2511.patch
deleted file mode 100644
index 8772f716d5..0000000000
--- a/meta/recipes-connectivity/openssl/openssl/CVE-2024-2511.patch
+++ /dev/null
@@ -1,120 +0,0 @@
1From e9d7083e241670332e0443da0f0d4ffb52829f08 Mon Sep 17 00:00:00 2001
2From: Matt Caswell <matt@openssl.org>
3Date: Tue, 5 Mar 2024 15:43:53 +0000
4Subject: [PATCH] Fix unconstrained session cache growth in TLSv1.3
5
6In TLSv1.3 we create a new session object for each ticket that we send.
7We do this by duplicating the original session. If SSL_OP_NO_TICKET is in
8use then the new session will be added to the session cache. However, if
9early data is not in use (and therefore anti-replay protection is being
10used), then multiple threads could be resuming from the same session
11simultaneously. If this happens and a problem occurs on one of the threads,
12then the original session object could be marked as not_resumable. When we
13duplicate the session object this not_resumable status gets copied into the
14new session object. The new session object is then added to the session
15cache even though it is not_resumable.
16
17Subsequently, another bug means that the session_id_length is set to 0 for
18sessions that are marked as not_resumable - even though that session is
19still in the cache. Once this happens the session can never be removed from
20the cache. When that object gets to be the session cache tail object the
21cache never shrinks again and grows indefinitely.
22
23CVE-2024-2511
24
25Reviewed-by: Neil Horman <nhorman@openssl.org>
26Reviewed-by: Tomas Mraz <tomas@openssl.org>
27(Merged from https://github.com/openssl/openssl/pull/24043)
28
29CVE: CVE-2024-2511
30Upstream-Status: Backport [https://github.com/openssl/openssl/commit/e9d7083e241670332e0443da0f0d4ffb52829f08]
31Signed-off-by: Peter Marko <peter.marko@siemens.com>
32---
33 ssl/ssl_lib.c | 5 +++--
34 ssl/ssl_sess.c | 28 ++++++++++++++++++++++------
35 ssl/statem/statem_srvr.c | 5 ++---
36 3 files changed, 27 insertions(+), 11 deletions(-)
37
38diff --git a/ssl/ssl_lib.c b/ssl/ssl_lib.c
39index 4afb43bc86e54..c51529ddab5bb 100644
40--- a/ssl/ssl_lib.c
41+++ b/ssl/ssl_lib.c
42@@ -4457,9 +4457,10 @@ void ssl_update_cache(SSL_CONNECTION *s, int mode)
43
44 /*
45 * If the session_id_length is 0, we are not supposed to cache it, and it
46- * would be rather hard to do anyway :-)
47+ * would be rather hard to do anyway :-). Also if the session has already
48+ * been marked as not_resumable we should not cache it for later reuse.
49 */
50- if (s->session->session_id_length == 0)
51+ if (s->session->session_id_length == 0 || s->session->not_resumable)
52 return;
53
54 /*
55diff --git a/ssl/ssl_sess.c b/ssl/ssl_sess.c
56index 3dcc4d81e5bc6..1fa6d17c46863 100644
57--- a/ssl/ssl_sess.c
58+++ b/ssl/ssl_sess.c
59@@ -127,16 +127,11 @@ SSL_SESSION *SSL_SESSION_new(void)
60 return ss;
61 }
62
63-SSL_SESSION *SSL_SESSION_dup(const SSL_SESSION *src)
64-{
65- return ssl_session_dup(src, 1);
66-}
67-
68 /*
69 * Create a new SSL_SESSION and duplicate the contents of |src| into it. If
70 * ticket == 0 then no ticket information is duplicated, otherwise it is.
71 */
72-SSL_SESSION *ssl_session_dup(const SSL_SESSION *src, int ticket)
73+static SSL_SESSION *ssl_session_dup_intern(const SSL_SESSION *src, int ticket)
74 {
75 SSL_SESSION *dest;
76
77@@ -265,6 +260,27 @@ SSL_SESSION *ssl_session_dup(const SSL_SESSION *src, int ticket)
78 return NULL;
79 }
80
81+SSL_SESSION *SSL_SESSION_dup(const SSL_SESSION *src)
82+{
83+ return ssl_session_dup_intern(src, 1);
84+}
85+
86+/*
87+ * Used internally when duplicating a session which might be already shared.
88+ * We will have resumed the original session. Subsequently we might have marked
89+ * it as non-resumable (e.g. in another thread) - but this copy should be ok to
90+ * resume from.
91+ */
92+SSL_SESSION *ssl_session_dup(const SSL_SESSION *src, int ticket)
93+{
94+ SSL_SESSION *sess = ssl_session_dup_intern(src, ticket);
95+
96+ if (sess != NULL)
97+ sess->not_resumable = 0;
98+
99+ return sess;
100+}
101+
102 const unsigned char *SSL_SESSION_get_id(const SSL_SESSION *s, unsigned int *len)
103 {
104 if (len)
105diff --git a/ssl/statem/statem_srvr.c b/ssl/statem/statem_srvr.c
106index 853af8c0aa9f9..d5f0ab091dacc 100644
107--- a/ssl/statem/statem_srvr.c
108+++ b/ssl/statem/statem_srvr.c
109@@ -2445,9 +2445,8 @@ CON_FUNC_RETURN tls_construct_server_hello(SSL_CONNECTION *s, WPACKET *pkt)
110 * so the following won't overwrite an ID that we're supposed
111 * to send back.
112 */
113- if (s->session->not_resumable ||
114- (!(SSL_CONNECTION_GET_CTX(s)->session_cache_mode & SSL_SESS_CACHE_SERVER)
115- && !s->hit))
116+ if (!(SSL_CONNECTION_GET_CTX(s)->session_cache_mode & SSL_SESS_CACHE_SERVER)
117+ && !s->hit)
118 s->session->session_id_length = 0;
119
120 if (usetls13) {
diff --git a/meta/recipes-connectivity/openssl/openssl_3.2.1.bb b/meta/recipes-connectivity/openssl/openssl_3.3.0.bb
index d37b68abbb..2cdaf4c75d 100644
--- a/meta/recipes-connectivity/openssl/openssl_3.2.1.bb
+++ b/meta/recipes-connectivity/openssl/openssl_3.3.0.bb
@@ -13,14 +13,13 @@ SRC_URI = "http://www.openssl.org/source/openssl-${PV}.tar.gz \
13 file://0001-Configure-do-not-tweak-mips-cflags.patch \ 13 file://0001-Configure-do-not-tweak-mips-cflags.patch \
14 file://0001-Added-handshake-history-reporting-when-test-fails.patch \ 14 file://0001-Added-handshake-history-reporting-when-test-fails.patch \
15 file://bti.patch \ 15 file://bti.patch \
16 file://CVE-2024-2511.patch \
17 " 16 "
18 17
19SRC_URI:append:class-nativesdk = " \ 18SRC_URI:append:class-nativesdk = " \
20 file://environment.d-openssl.sh \ 19 file://environment.d-openssl.sh \
21 " 20 "
22 21
23SRC_URI[sha256sum] = "83c7329fe52c850677d75e5d0b0ca245309b97e8ecbcfdc1dfdc4ab9fac35b39" 22SRC_URI[sha256sum] = "53e66b043322a606abf0087e7699a0e033a37fa13feb9742df35c3a33b18fb02"
24 23
25inherit lib_package multilib_header multilib_script ptest perlnative manpages 24inherit lib_package multilib_header multilib_script ptest perlnative manpages
26MULTILIB_SCRIPTS = "${PN}-bin:${bindir}/c_rehash" 25MULTILIB_SCRIPTS = "${PN}-bin:${bindir}/c_rehash"