summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPeter Kjellerstedt <peter.kjellerstedt@axis.com>2024-01-22 06:52:32 +0100
committerRichard Purdie <richard.purdie@linuxfoundation.org>2024-02-20 11:39:45 +0000
commit1648d0e8f7327eb8ff34da2352e16f2591654be3 (patch)
treef422b4464f2425969c546f8c0bbb549b8d371f69
parent9f7475b4e5219da89f04c21a96d54e76fc6a6960 (diff)
downloadpoky-1648d0e8f7327eb8ff34da2352e16f2591654be3.tar.gz
insane.bbclass: Allow the warning about virtual/ to be disabled
Commit f673d3d239799fb1ab50f4aa5d44187666aa0cd7 introduced a warning for virtual/ being used in RPROVIDES and RDEPENDS. Make it possible to disable the warning by removing "virtual-slash from WARN_QA. (From OE-Core rev: 968ffdb9fee5017eecce36ce878ea604c869ce95) Signed-off-by: Peter Kjellerstedt <peter.kjellerstedt@axis.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
-rw-r--r--meta/classes-global/insane.bbclass13
1 files changed, 7 insertions, 6 deletions
diff --git a/meta/classes-global/insane.bbclass b/meta/classes-global/insane.bbclass
index 9909526f51..e963001d09 100644
--- a/meta/classes-global/insane.bbclass
+++ b/meta/classes-global/insane.bbclass
@@ -34,7 +34,7 @@ WARN_QA ?= " libdir xorg-driver-abi buildpaths \
34 missing-update-alternatives native-last missing-ptest \ 34 missing-update-alternatives native-last missing-ptest \
35 license-exists license-no-generic license-syntax license-format \ 35 license-exists license-no-generic license-syntax license-format \
36 license-incompatible license-file-missing obsolete-license \ 36 license-incompatible license-file-missing obsolete-license \
37 32bit-time \ 37 32bit-time virtual-slash \
38 " 38 "
39ERROR_QA ?= "dev-so debug-deps dev-deps debug-files arch pkgconfig la \ 39ERROR_QA ?= "dev-so debug-deps dev-deps debug-files arch pkgconfig la \
40 perms dep-cmp pkgvarcheck perm-config perm-line perm-link \ 40 perms dep-cmp pkgvarcheck perm-config perm-line perm-link \
@@ -1607,11 +1607,12 @@ python () {
1607 if (d.getVar(d.expand('DEPENDS:${PN}'))): 1607 if (d.getVar(d.expand('DEPENDS:${PN}'))):
1608 oe.qa.handle_error("pkgvarcheck", "recipe uses DEPENDS:${PN}, should use DEPENDS", d) 1608 oe.qa.handle_error("pkgvarcheck", "recipe uses DEPENDS:${PN}, should use DEPENDS", d)
1609 1609
1610 # virtual/ is meaningless for those variables 1610 # virtual/ is meaningless for these variables
1611 for k in ['RDEPENDS', 'RPROVIDES']: 1611 if "virtual-slash" in (d.getVar("ALL_QA") or "").split():
1612 for var in bb.utils.explode_deps(d.getVar(k + ':' + pn) or ""): 1612 for k in ['RDEPENDS', 'RPROVIDES']:
1613 if var.startswith("virtual/"): 1613 for var in bb.utils.explode_deps(d.getVar(k + ':' + pn) or ""):
1614 bb.warn("%s is set to %s but the substring 'virtual/' holds no meaning in this context. It only works for build time dependencies, not runtime ones. It is suggested to use 'VIRTUAL-RUNTIME_' variables instead." % (k, var)) 1614 if var.startswith("virtual/"):
1615 oe.qa.handle_error("virtual-slash", "%s is set to %s but the substring 'virtual/' holds no meaning in this context. It only works for build time dependencies, not runtime ones. It is suggested to use 'VIRTUAL-RUNTIME_' variables instead." % (k, var), d)
1615 1616
1616 issues = [] 1617 issues = []
1617 if (d.getVar('PACKAGES') or "").split(): 1618 if (d.getVar('PACKAGES') or "").split():