summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRoss Burton <ross@burtonini.com>2021-10-14 17:33:18 +0100
committerRichard Purdie <richard.purdie@linuxfoundation.org>2021-11-03 11:18:56 +0000
commit59ad5783a596e2d1cd281f5134c06cb2f1f87949 (patch)
treea3e6cb531400822f790d1b4f87d3d4c82ba83759
parent990c499176629fa4d9a6f7cf01f0208d32723f45 (diff)
downloadpoky-59ad5783a596e2d1cd281f5134c06cb2f1f87949.tar.gz
oe/utils: log exceptions in ThreadedWorker functions
If the function a ThreadedWorker is executing raises an exception, don't use print() as that mostly disappears. Instead, output it to the logger. This is done using bb.mainlogger.debug directly instead of bb.debug() as this allows us to pass the exception instance directly, which is then incorporated into the log stream. (From OE-Core rev: 3bad17c8cf58b2bfc36a1de754fa47fb344bd5d8) Signed-off-by: Ross Burton <ross.burton@arm.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> (cherry picked from commit 2f1ea25c222b344dd8b784b2bc73a6540ab30274) Signed-off-by: Steve Sakoman <steve@sakoman.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
-rw-r--r--meta/lib/oe/utils.py3
1 files changed, 2 insertions, 1 deletions
diff --git a/meta/lib/oe/utils.py b/meta/lib/oe/utils.py
index 83d298906b..3e016244c5 100644
--- a/meta/lib/oe/utils.py
+++ b/meta/lib/oe/utils.py
@@ -481,7 +481,8 @@ class ThreadedWorker(Thread):
481 try: 481 try:
482 func(self, *args, **kargs) 482 func(self, *args, **kargs)
483 except Exception as e: 483 except Exception as e:
484 print(e) 484 # Eat all exceptions
485 bb.mainlogger.debug("Worker task raised %s" % e, exc_info=e)
485 finally: 486 finally:
486 self.tasks.task_done() 487 self.tasks.task_done()
487 488