summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMario Domenech Goulart <mario@ossystems.com.br>2015-05-12 11:03:40 -0300
committerRichard Purdie <richard.purdie@linuxfoundation.org>2015-05-16 22:31:50 +0100
commit24b8347724b3482dd2a1f6e7d69ac41aa437ade0 (patch)
treef6e8920aee30e9eeb898a3b86582e1ab08ab02f8
parentcdf81801ba10caa87b857a2c345405e6a7db2547 (diff)
downloadpoky-24b8347724b3482dd2a1f6e7d69ac41aa437ade0.tar.gz
native.bbclass: avoid unintended substring replacement when setting PROVIDES
The way native_virtclass_handler was implemented leaded to unintended substring replacements when setting PROVIDES for native providers, in case the original PROVIDES value contains providees with common substrings. Here's a practical case where the old behavior was problematic: the oracle-jse-jdk-x86-64 recipe provides both virtual/java and virtual/javac: Before: $ bitbake -e oracle-jse-jdk-x86-64-native | grep ^PROVIDES= PROVIDES="oracle-jse-jdk-x86-64-native virtual/java-native virtual/java-nativec" After: $ bitbake -e oracle-jse-jdk-x86-64-native | grep ^PROVIDES= PROVIDES="oracle-jse-jdk-x86-64-native virtual/java-native virtual/javac-native" Change-Id: I8186992dae58e37c2a2364586360ff9b7da9198f (From OE-Core rev: c28291f1fb07fbc80275d9bceefed642c963e204) Signed-off-by: Mario Domenech Goulart <mario@ossystems.com.br> Signed-off-by: Ross Burton <ross.burton@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
-rw-r--r--meta/classes/native.bbclass5
1 files changed, 3 insertions, 2 deletions
diff --git a/meta/classes/native.bbclass b/meta/classes/native.bbclass
index 5ca5c95b4d..1f8139bec8 100644
--- a/meta/classes/native.bbclass
+++ b/meta/classes/native.bbclass
@@ -151,12 +151,13 @@ python native_virtclass_handler () {
151 map_dependencies("RREPLACES", e.data, pkg) 151 map_dependencies("RREPLACES", e.data, pkg)
152 152
153 provides = e.data.getVar("PROVIDES", True) 153 provides = e.data.getVar("PROVIDES", True)
154 nprovides = []
154 for prov in provides.split(): 155 for prov in provides.split():
155 if prov.find(pn) != -1: 156 if prov.find(pn) != -1:
156 continue 157 continue
157 if not prov.endswith("-native"): 158 if not prov.endswith("-native"):
158 provides = provides.replace(prov, prov + "-native") 159 nprovides.append(prov.replace(prov, prov + "-native"))
159 e.data.setVar("PROVIDES", provides) 160 e.data.setVar("PROVIDES", ' '.join(nprovides))
160 161
161 e.data.setVar("OVERRIDES", e.data.getVar("OVERRIDES", False) + ":virtclass-native") 162 e.data.setVar("OVERRIDES", e.data.getVar("OVERRIDES", False) + ":virtclass-native")
162} 163}