summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPaul Eggleton <paul.eggleton@linux.intel.com>2012-01-13 17:01:47 +0000
committerRichard Purdie <richard.purdie@linuxfoundation.org>2012-01-15 10:06:21 +0000
commit4e8085ccfa38f491edb7566a3d02795b8b5e6f73 (patch)
tree58c417e8f7db0c0c306c119a2466b2e646d14675
parentdcf6b641fe3a9a1525290da788648aab3204d48c (diff)
downloadpoky-4e8085ccfa38f491edb7566a3d02795b8b5e6f73.tar.gz
bitbake/runqueue: avoid "failed" in task summary if nothing did
Seeing the word "failed" alone without reading the whole context has occasionally triggered an automatic assumption on the part of some users (myself included) that something has gone wrong, even when this message is telling you that "0 [tasks] failed". To avoid this let's just say "all succeeded" in this case instead. As a bonus this means you can now search the output for "fail" and not find anything if all went well. (Bitbake rev: b6f067af12d4661758a78788f1db472684b9aba8) Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
-rw-r--r--bitbake/lib/bb/runqueue.py6
1 files changed, 5 insertions, 1 deletions
diff --git a/bitbake/lib/bb/runqueue.py b/bitbake/lib/bb/runqueue.py
index 86744fbaef..054d36cf16 100644
--- a/bitbake/lib/bb/runqueue.py
+++ b/bitbake/lib/bb/runqueue.py
@@ -968,7 +968,11 @@ class RunQueue:
968 968
969 if self.state is runQueueComplete: 969 if self.state is runQueueComplete:
970 # All done 970 # All done
971 logger.info("Tasks Summary: Attempted %d tasks of which %d didn't need to be rerun and %d failed.", self.rqexe.stats.completed, self.rqexe.stats.skipped, self.rqexe.stats.failed) 971 if self.rqexe.stats.failed:
972 logger.info("Tasks Summary: Attempted %d tasks of which %d didn't need to be rerun and %d failed.", self.rqexe.stats.completed, self.rqexe.stats.skipped, self.rqexe.stats.failed)
973 else:
974 # Let's avoid the word "failed" if nothing actually did
975 logger.info("Tasks Summary: Attempted %d tasks of which %d didn't need to be rerun and all succeeded.", self.rqexe.stats.completed, self.rqexe.stats.skipped)
972 return False 976 return False
973 977
974 if self.state is runQueueChildProcess: 978 if self.state is runQueueChildProcess: