summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRichard Purdie <richard.purdie@linuxfoundation.org>2015-06-25 16:47:28 +0100
committerRichard Purdie <richard.purdie@linuxfoundation.org>2015-06-26 09:27:31 +0100
commitffd7cac8f6a82ddf9c29795f90b8a0bc2096fd1a (patch)
treef50fd16cc3e24038203335a6e1f477d6d06ce8da
parente8c50a2b7fe229cde8f00896ec7e908b280215ec (diff)
downloadpoky-ffd7cac8f6a82ddf9c29795f90b8a0bc2096fd1a.tar.gz
oeqa/selftest/recipetool: Fix appendfile_binary test on opensuse131
On OpenSUSE 13.1, /bin/ls is a symlink to /usr/bin/ls. This means the test doesn't use a binary file an fails on that system. Ensure we resolve any symlink using readlink to avoid this failure. ====================================================================== FAIL: test_recipetool_appendfile_binary (oeqa.selftest.recipetool.RecipetoolTests) ---------------------------------------------------------------------- Traceback (most recent call last): File "/home/pokybuild/yocto-autobuilder/yocto-worker/nightly-oe-selftest/build/meta/lib/oeqa/selftest/recipetool.py", line 115, in test_recipetool_appendfile_binary self.assertIn('WARNING: ', result.output) AssertionError: 'WARNING: ' not found in 'Parsing recipes..done.\nNOTE: Writing append file /tmp/recipetoolqai0NY8l/recipes-core/coreutils/coreutils_8.23.bbappend\nNOTE: Copying /bin/ls to /tmp/recipetoolqai0NY8l/recipes-core/coreutils/coreutils/ls' [YOCTO #7920] (From OE-Core rev: 792107de1586336f4a734557c0c3fa36a1174e9e) Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
-rw-r--r--meta/lib/oeqa/selftest/recipetool.py4
1 files changed, 3 insertions, 1 deletions
diff --git a/meta/lib/oeqa/selftest/recipetool.py b/meta/lib/oeqa/selftest/recipetool.py
index f3ad493457..c08b2e4674 100644
--- a/meta/lib/oeqa/selftest/recipetool.py
+++ b/meta/lib/oeqa/selftest/recipetool.py
@@ -111,7 +111,9 @@ class RecipetoolTests(DevtoolBase):
111 111
112 def test_recipetool_appendfile_binary(self): 112 def test_recipetool_appendfile_binary(self):
113 # Try appending a binary file 113 # Try appending a binary file
114 result = runCmd('recipetool appendfile %s /bin/ls /bin/ls -r coreutils' % templayerdir) 114 # /bin/ls can be a symlink to /usr/bin/ls
115 ls = os.readlink("/bin/ls")
116 result = runCmd('recipetool appendfile %s /bin/ls %s -r coreutils' % (templayerdir, ls))
115 self.assertIn('WARNING: ', result.output) 117 self.assertIn('WARNING: ', result.output)
116 self.assertIn('is a binary', result.output) 118 self.assertIn('is a binary', result.output)
117 119