diff options
author | Ross Burton <ross@burtonini.com> | 2021-03-08 18:01:49 +0000 |
---|---|---|
committer | Richard Purdie <richard.purdie@linuxfoundation.org> | 2021-03-18 21:20:25 +0000 |
commit | d4fffe3b6664cde0b6c66df54d283f27b8a7acb0 (patch) | |
tree | 91c5d3cf825c5c4f9cdf9b5359b586a321e9e26d | |
parent | c92107bda7b6c22e72c10f574b053f163e7092c2 (diff) | |
download | poky-d4fffe3b6664cde0b6c66df54d283f27b8a7acb0.tar.gz |
insane: don't check for a warning string that is never output
insane has checks that the compiler isn't printing "CROSS COMPILE
Badness" during configure/compile/install, but this message hasn't been
output by GCC since 2010 (23f522e7).
The current warning is "include location [...] is unsafe for cross-
compilation" and as that is a proper GCC warning, we can make it fatal
in follow-up patches.
(From OE-Core rev: 32c49bc10013ece820c9168b690d14a5a9fd1f13)
Signed-off-by: Ross Burton <ross.burton@arm.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
(cherry picked from commit a67e9ebfd5b8002fd4a7d8d27ff0d997817f76e1)
Signed-off-by: Steve Sakoman <steve@sakoman.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
-rw-r--r-- | meta/classes/insane.bbclass | 22 |
1 files changed, 1 insertions, 21 deletions
diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass index b5c6b2186f..09e8fbd8e4 100644 --- a/meta/classes/insane.bbclass +++ b/meta/classes/insane.bbclass | |||
@@ -1012,26 +1012,6 @@ python do_package_qa () { | |||
1012 | logdir = d.getVar('T') | 1012 | logdir = d.getVar('T') |
1013 | pn = d.getVar('PN') | 1013 | pn = d.getVar('PN') |
1014 | 1014 | ||
1015 | # Check the compile log for host contamination | ||
1016 | compilelog = os.path.join(logdir,"log.do_compile") | ||
1017 | |||
1018 | if os.path.exists(compilelog): | ||
1019 | statement = "grep -e 'CROSS COMPILE Badness:' -e 'is unsafe for cross-compilation' %s > /dev/null" % compilelog | ||
1020 | if subprocess.call(statement, shell=True) == 0: | ||
1021 | msg = "%s: The compile log indicates that host include and/or library paths were used.\n \ | ||
1022 | Please check the log '%s' for more information." % (pn, compilelog) | ||
1023 | package_qa_handle_error("compile-host-path", msg, d) | ||
1024 | |||
1025 | # Check the install log for host contamination | ||
1026 | installlog = os.path.join(logdir,"log.do_install") | ||
1027 | |||
1028 | if os.path.exists(installlog): | ||
1029 | statement = "grep -e 'CROSS COMPILE Badness:' -e 'is unsafe for cross-compilation' %s > /dev/null" % installlog | ||
1030 | if subprocess.call(statement, shell=True) == 0: | ||
1031 | msg = "%s: The install log indicates that host include and/or library paths were used.\n \ | ||
1032 | Please check the log '%s' for more information." % (pn, installlog) | ||
1033 | package_qa_handle_error("install-host-path", msg, d) | ||
1034 | |||
1035 | # Scan the packages... | 1015 | # Scan the packages... |
1036 | pkgdest = d.getVar('PKGDEST') | 1016 | pkgdest = d.getVar('PKGDEST') |
1037 | packages = set((d.getVar('PACKAGES') or '').split()) | 1017 | packages = set((d.getVar('PACKAGES') or '').split()) |
@@ -1210,7 +1190,7 @@ python do_qa_configure() { | |||
1210 | if bb.data.inherits_class('autotools', d) and not skip_configure_unsafe: | 1190 | if bb.data.inherits_class('autotools', d) and not skip_configure_unsafe: |
1211 | bb.note("Checking autotools environment for common misconfiguration") | 1191 | bb.note("Checking autotools environment for common misconfiguration") |
1212 | for root, dirs, files in os.walk(workdir): | 1192 | for root, dirs, files in os.walk(workdir): |
1213 | statement = "grep -q -F -e 'CROSS COMPILE Badness:' -e 'is unsafe for cross-compilation' %s" % \ | 1193 | statement = "grep -q -F -e 'is unsafe for cross-compilation' %s" % \ |
1214 | os.path.join(root,"config.log") | 1194 | os.path.join(root,"config.log") |
1215 | if "config.log" in files: | 1195 | if "config.log" in files: |
1216 | if subprocess.call(statement, shell=True) == 0: | 1196 | if subprocess.call(statement, shell=True) == 0: |